fix: isValidName - num should not an valid name

Author: inhere

composer.json

@@ -40,6 +40,7 @@
     "test": "vendor/bin/phpunit"
   },
   "suggest": {
+    "toolkit/pflag": "Command line flag parse library of the php",
     "inhere/console": "a lightweight php console application library."
   }
 }

src/App.php

@@ -305,7 +305,7 @@ public function addObject(callable $handler, array $config = []): void
      */
     public function addByConfig(callable $handler, array $config): void
     {
-        if (empty($config['name']) || !$handler) {
+        if (empty($config['name'])) {
             throw new InvalidArgumentException('Invalid arguments for add command');
         }
 
@@ -329,7 +329,7 @@ public function add(string $command, callable $handler, $config = null): void
      */
     public function addCommand(string $command, callable $handler, $config = null): void
     {
-        if (!$command || !$handler) {
+        if (!$command) {
             throw new InvalidArgumentException('Invalid arguments for add command');
         }
 

src/Cli.php

@@ -51,6 +51,8 @@
  * @method static error(string ...$message) Print error style message line.
  * @method static warn(string ...$message) Print warn style message line.
  * @method static info(string ...$message) Print info style message line.
+ * @method static note(string ...$message) Print note style message line.
+ * @method static notice(string ...$message) Print notice style message line.
  * @method static success(string ...$message) Print success style message line.
  */
 class Cli

src/Helper/FlagHelper.php

@@ -112,7 +112,7 @@ public static function isOptionValue($val): bool
      */
     public static function isValidName(string $name): bool
     {
-        return preg_match('#^\w[\w-]{0,36}$#', $name) === 1;
+        return preg_match('#^[a-zA-Z_][\w-]{0,36}$#', $name) === 1;
     }
 
     /**

test/FlagsTest.php

@@ -81,10 +81,4 @@ public function testStopParseOnTwoHl(): void
         $this->assertSame('--age', $args[0]);
         $this->assertCount(4, $args);
     }
-
-    public function testIsValidArgName(): void
-    {
-        $this->assertTrue(FlagHelper::isValidName('arg0'));
-        $this->assertFalse(FlagHelper::isValidName('/path/to'));
-    }
 }

test/Helper/FlagHelperTest.php

@@ -10,6 +10,14 @@
  */
 class FlagHelperTest extends TestCase
 {
+
+    public function testIsValidArgName1(): void
+    {
+        $this->assertTrue(FlagHelper::isValidName('arg0'));
+        $this->assertFalse(FlagHelper::isValidName('9'));
+        $this->assertFalse(FlagHelper::isValidName('/path/to'));
+    }
+
     public function testIsValidName(): void
     {
         $tests = [
@@ -26,10 +34,12 @@ public function testIsValidName(): void
             '-name'     => false,
             ' name'     => false,
             '+name'     => false,
+            3           => false,
+            30          => false,
         ];
 
         foreach ($tests as $name => $ok) {
-            $this->assertSame($ok, FlagHelper::isValidName($name));
+            $this->assertSame($ok, FlagHelper::isValidName((string)$name));
         }
     }
 }