Merge pull request #347 from odolbeau/update-commands

Commands should always return int

Author: welcoMattic

Command/DeleteObsoleteCommand.php

@@ -91,14 +91,14 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if (0 === $messageCount) {
             $output->writeln('No messages are obsolete');
 
-            return;
+            return 0;
         }
 
         if ($input->isInteractive()) {
             $helper = $this->getHelper('question');
             $question = new ConfirmationQuestion(\sprintf('You are about to remove %d translations. Do you wish to continue? (y/N) ', $messageCount), false);
             if (!$helper->ask($input, $output, $question)) {
-                return;
+                return 0;
             }
         }
 
@@ -125,5 +125,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if ($progress) {
             $progress->finish();
         }
+
+        return 0;
     }
 }

Command/DownloadCommand.php

@@ -83,6 +83,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
         } else {
             $storage->download();
         }
+
+        return 0;
     }
 
     private function hashDirectory($directory)

Command/ExtractCommand.php

@@ -131,6 +131,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 );
             }
         }
+
+        return 0;
     }
 
     /**

Command/StatusCommand.php

@@ -89,7 +89,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if ($input->getOption('json')) {
             $output->writeln(\json_encode($stats));
 
-            return;
+            return 0;
         }
 
         $io = new SymfonyStyle($input, $output);
@@ -101,5 +101,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $io->title('Locale: '.$locale);
             $io->table(['Domain', 'Defined', 'New', 'Obsolete'], $rows);
         }
+
+        return 0;
     }
 }

Command/SyncCommand.php

@@ -57,9 +57,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
             default:
                 $output->writeln(\sprintf('Direction must be either "up" or "down". Not "%s".', $input->getArgument('direction')));
 
-                return;
+                return 0;
         }
 
         $this->getStorage($input->getArgument('configuration'))->sync($direction);
+
+        return 0;
     }
 }