Bump phpstan from 1.x to 2.x and remove unnecessary psalm annotations

Author: Kirill Nesmeyanov

composer.json

@@ -23,9 +23,9 @@
         "friendsofphp/php-cs-fixer": "^3.53",
         "jetbrains/phpstorm-attributes": "^1.0",
         "phplrt/compiler": "^3.7",
-        "phpstan/extension-installer": "^1.4",
-        "phpstan/phpstan": "^1.11",
-        "phpstan/phpstan-strict-rules": "^1.6",
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-deprecation-rules": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^10.5|^11.0",
         "rector/rector": "^1.1"
     },
@@ -47,9 +47,6 @@
         "optimize-autoloader": true,
         "preferred-install": {
             "*": "dist"
-        },
-        "allow-plugins": {
-            "phpstan/extension-installer": true
         }
     },
     "scripts": {

phpstan.neon

@@ -1,7 +1,9 @@
 includes:
   - phar://phpstan.phar/conf/bleedingEdge.neon
+  - vendor/phpstan/phpstan-deprecation-rules/rules.neon
+  - vendor/phpstan/phpstan-strict-rules/rules.neon
 parameters:
-  level: 9
+  level: max
   strictRules:
     allRules: true
   fileExtensions:

src/Node/Literal/BoolLiteralNode.php

@@ -7,8 +7,6 @@
 /**
  * @template-extends LiteralNode<bool>
  *
- * @psalm-consistent-constructor
- *
  * @phpstan-consistent-constructor
  */
 class BoolLiteralNode extends LiteralNode implements ParsableLiteralNodeInterface

src/Node/Literal/FloatLiteralNode.php

@@ -7,8 +7,6 @@
 /**
  * @template-extends LiteralNode<float>
  *
- * @psalm-consistent-constructor
- *
  * @phpstan-consistent-constructor
  */
 class FloatLiteralNode extends LiteralNode implements ParsableLiteralNodeInterface

src/Node/Literal/IntLiteralNode.php

@@ -7,8 +7,6 @@
 /**
  * @template-extends LiteralNode<int>
  *
- * @psalm-consistent-constructor
- *
  * @phpstan-consistent-constructor
  */
 class IntLiteralNode extends LiteralNode implements ParsableLiteralNodeInterface

src/Node/Literal/StringLiteralNode.php

@@ -7,8 +7,6 @@
 /**
  * @template-extends LiteralNode<string>
  *
- * @psalm-consistent-constructor
- *
  * @phpstan-consistent-constructor
  */
 class StringLiteralNode extends LiteralNode implements ParsableLiteralNodeInterface
@@ -143,7 +141,6 @@ private static function renderHexadecimalSequences(string $body): string
             => \chr((int) \hexdec((string) $matches[1]))
         ;
 
-        /** @psalm-suppress InvalidArgument */
         return @\preg_replace_callback(self::HEX_SEQUENCE_PATTERN, $callee, $body) ?? $body;
     }
 
@@ -184,7 +181,6 @@ private static function renderUtfSequences(string $body): string
                 . \chr(0x80 | $code & 0x3F);
         };
 
-        /** @psalm-suppress InvalidArgument */
         return @\preg_replace_callback(self::UTF_SEQUENCE_PATTERN, $callee, $body) ?? $body;
     }
 

src/Node/Literal/VariableLiteralNode.php

@@ -7,8 +7,6 @@
 /**
  * @template-extends LiteralNode<non-empty-string>
  *
- * @psalm-consistent-constructor
- *
  * @phpstan-consistent-constructor
  */
 class VariableLiteralNode extends LiteralNode implements ParsableLiteralNodeInterface

src/Parser.php

@@ -76,8 +76,6 @@ final class Parser implements ParserInterface
 
     /**
      * @var int<0, max>
-     *
-     * @psalm-readonly-allow-private-mutation
      */
     public int $lastProcessedTokenOffset = 0;
 

src/ParserInterface.php

@@ -18,8 +18,6 @@ interface ParserInterface
      *
      * @throws ParserExceptionInterface in case of parsing exception occurs
      * @throws \Throwable in case of internal error occurs
-     *
-     * @psalm-suppress UndefinedAttributeClass : Optional (builtin) attribute usage
      */
     public function parse(#[Language('PHP')] mixed $source): TypeStatement;
 }

src/Traverser.php

@@ -50,9 +50,6 @@ public static function new(iterable $visitors = []): self
         return new self($visitors);
     }
 
-    /**
-     * @psalm-immutable
-     */
     public function with(VisitorInterface $visitor, bool $prepend = false): self
     {
         $self = clone $this;
@@ -101,7 +98,6 @@ private function applyToNode(Node $node): void
             $command = $visitor->enter($node);
 
             if ($command === null) {
-                /** @psalm-suppress MixedAssignment */
                 foreach ($this->getProperties($node) as $property) {
                     if ($property instanceof Node) {
                         $this->applyToNode($property);