Better error message

André L F S Bacci · André L F S Bacci · commit 8f710c415ad1 · 2024-11-25T11:29:00.000-03:00
diff --git a/scripts/translation/lib/GitLogParser.php b/scripts/translation/lib/GitLogParser.php
@@ -77,7 +77,6 @@ static function parseDir( string $gdir , RevcheckFileList $list )
                 $lcnt++;
                 if ( $lcnt == 1 && str_starts_with( trim( $proc->line ) , '[skip-revcheck]' ) )
                     $skip = true;
-
                 $proc->next();
             }
 
diff --git a/scripts/translation/lib/RevcheckRun.php b/scripts/translation/lib/RevcheckRun.php
@@ -208,7 +208,11 @@ private function parseTranslationXml() : void
         $this->revData->lang = $this->targetDir;
         $this->revData->date = date("r");
 
-        $dom = XmlUtil::loadFile( $this->targetDir . '/translation.xml' );
+        $transfile = $this->targetDir . '/translation.xml';
+        if ( ! file_exists( $transfile ) )
+            throw new \Exception("Missing translation.xml file." );
+
+        $dom = XmlUtil::loadFile( $transfile );
 
         $tag = $dom->getElementsByTagName( 'intro' )[0] ?? null;
         if ( $tag == null )

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ static function parseDir( string $gdir , RevcheckFileList $list )`
`77`	`77`	`$lcnt++;`
`78`	`78`	`if ( $lcnt == 1 && str_starts_with( trim( $proc->line ) , '[skip-revcheck]' ) )`
`79`	`79`	`$skip = true;`
`80`		`-`
`81`	`80`	`$proc->next();`
`82`	`81`	`}`
`83`	`82`