Revert ValueError back to Warning

Girgias · Girgias · commit 20bb3bbc6a43 · 2020-08-07T12:44:46.000+02:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -3710,7 +3710,8 @@ static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req
 	EVP_PKEY * return_val = NULL;
 
 	if (req->priv_key_bits < MIN_KEY_LENGTH) {
-		zend_value_error("Private key must be at least %d bits", MIN_KEY_LENGTH);
+		php_error_docref(NULL, E_WARNING, "Private key length must be at least %d bits, configured to %d",
+			MIN_KEY_LENGTH, req->priv_key_bits);
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -3710,7 +3710,8 @@ static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req`
`3710`	`3710`	`EVP_PKEY * return_val = NULL;`
`3711`	`3711`
`3712`	`3712`	`if (req->priv_key_bits < MIN_KEY_LENGTH) {`
`3713`		`- zend_value_error("Private key must be at least %d bits", MIN_KEY_LENGTH);`
	`3713`	`+ php_error_docref(NULL, E_WARNING, "Private key length must be at least %d bits, configured to %d",`
	`3714`	`+ MIN_KEY_LENGTH, req->priv_key_bits);`
`3714`	`3715`	`return NULL;`
`3715`	`3716`	`}`
`3716`	`3717`