dom: Fix missing NUL byte check on C14NFile()

ndossche · ndossche · commit 8ad59157561f · 2025-11-13T00:03:13.000+01:00
Closes GH-20466.
diff --git a/NEWS b/NEWS
@@ -11,6 +11,9 @@ PHP                                                                        NEWS
   . Fix crashes when trying to instantiate uninstantiable classes via date
     static constructors. (ndossche)
 
+- DOM:
+  . Fix missing NUL byte check on C14NFile(). (ndossche)
+
 - Opcache:
   . Fixed bug GH-20329 (opcache.file_cache broken with full interned string
     buffer). (Arnaud)
diff --git a/ext/dom/node.c b/ext/dom/node.c
@@ -1857,7 +1857,7 @@ static void dom_canonicalization(INTERNAL_FUNCTION_PARAMETERS, int mode) /* {{{
 		}
 	} else {
 		if (zend_parse_parameters(ZEND_NUM_ARGS(),
-			"s|bba!a!", &file, &file_len, &exclusive,
+			"p|bba!a!", &file, &file_len, &exclusive,
 			&with_comments, &xpath_array, &ns_prefixes) == FAILURE) {
 			RETURN_THROWS();
 		}

Original file line number	Diff line number	Diff line change
`@@ -1857,7 +1857,7 @@ static void dom_canonicalization(INTERNAL_FUNCTION_PARAMETERS, int mode) /* {{{`
`1857`	`1857`	`}`
`1858`	`1858`	`} else {`
`1859`	`1859`	`if (zend_parse_parameters(ZEND_NUM_ARGS(),`
`1860`		`- "s\|bba!a!", &file, &file_len, &exclusive,`
	`1860`	`+ "p\|bba!a!", &file, &file_len, &exclusive,`
`1861`	`1861`	`&with_comments, &xpath_array, &ns_prefixes) == FAILURE) {`
`1862`	`1862`	`RETURN_THROWS();`
`1863`	`1863`	`}`