Revert ValueError back to Warning

Girgias · Girgias · commit bf9cf3dd500c · 2020-08-11T00:16:38.000+02:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -3658,7 +3658,8 @@ static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req
 	EVP_PKEY * return_val = NULL;
 
 	if (req->priv_key_bits < MIN_KEY_LENGTH) {
-		zend_value_error("Private key must be at least %d bits", MIN_KEY_LENGTH);
+		php_error_docref(NULL, E_WARNING, "Private key length must be at least %d bits, configured to %d",
+			MIN_KEY_LENGTH, req->priv_key_bits);
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -3658,7 +3658,8 @@ static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req`
`3658`	`3658`	`EVP_PKEY * return_val = NULL;`
`3659`	`3659`
`3660`	`3660`	`if (req->priv_key_bits < MIN_KEY_LENGTH) {`
`3661`		`- zend_value_error("Private key must be at least %d bits", MIN_KEY_LENGTH);`
	`3661`	`+ php_error_docref(NULL, E_WARNING, "Private key length must be at least %d bits, configured to %d",`
	`3662`	`+ MIN_KEY_LENGTH, req->priv_key_bits);`
`3662`	`3663`	`return NULL;`
`3663`	`3664`	`}`
`3664`	`3665`