Merge pull request #1249 from phpDocumentor/bugfix/numbered-lists

[BUGFIX] Numbered lists should continue numbering

Author: jaapio

packages/guides-markdown/src/Markdown/Parsers/ListBlockParser.php

@@ -49,7 +49,13 @@ public function parse(MarkupLanguageParser $parser, NodeWalker $walker, CommonMa
             }
 
             if ($commonMarkNode instanceof ListBlock) {
-                return new ListNode($content, $content[0]->isOrdered());
+                $start = $commonMarkNode->getListData()->start;
+
+                return new ListNode(
+                    $content,
+                    $content[0]->isOrdered(),
+                    $start !== null && $start !== 1 ? (string) $start : null,
+                );
             }
 
             $this->logger->warning(sprintf('"%s" node is not yet supported in context %s. ', $commonMarkNode::class, 'List'));

tests/Integration/tests/lists/numbered-lists-defined/expected/index.html

@@ -26,6 +26,17 @@ <h1>Document Title</h1>
     <li>This is the second item.</li>
 </ol>
 </li>
+    <li value="1">First</li>
+    <li value="2">Second</li>
+</ol>
+
+
+    <p>Intermediary text or image.</p>
+
+
+
+<ol start="3" type="1">
+    <li value="3">Third</li>
 </ol>
 
     </div>

tests/Integration/tests/lists/numbered-lists-defined/input/index.rst

@@ -14,3 +14,10 @@ Lorem Ipsum Dolor
 
     1. This is an indented numbered list.
     #. This is the second item.
+
+1. First
+2. Second
+
+Intermediary text or image.
+
+3. Third

tests/Integration/tests/markdown/lists-md/expected/index.html

@@ -39,6 +39,25 @@ <h2>Ordered</h2>
     <li>Third item</li>
 </ol>
 
+    </div>
+            <div class="section" id="ordered-continued">
+            <h2>Ordered, continued</h2>
+
+
+<ol>
+    <li>First</li>
+    <li>Second</li>
+</ol>
+
+
+    <p>Intermediary text or image.</p>
+
+
+
+<ol start="3">
+    <li>Third</li>
+</ol>
+
     </div>
     </div>
 <!-- content end -->

tests/Integration/tests/markdown/lists-md/input/index.md

@@ -14,3 +14,12 @@
     1. Subitem A
     2. Subitem B
 3. Third item
+
+## Ordered, continued
+
+1. First
+2. Second
+
+Intermediary text or image.
+
+3. Third