Use deque for buffer

Author: Anton Shabouta

Buffer.cpp

@@ -13,10 +13,6 @@
 Buffer::Buffer() noexcept {
 }
 
-Buffer::Buffer(const std::vector<unsigned char> &_buffer) noexcept:
-    buffer(_buffer) {
-}
-
 void Buffer::clear() noexcept {
     buffer.clear();
 }
@@ -67,8 +63,7 @@ template <class T> inline void Buffer::append(const T &val) noexcept {
     unsigned int size = sizeof(T);
     unsigned const char *array = reinterpret_cast<unsigned const char*>(&val);
 
-    for (unsigned int i = 0; i < size; ++i)
-        buffer.push_back(array[size - i - 1]);
+    buffer.insert(buffer.end(), array, array + size);
 }
 
 void Buffer::appendBoolean(bool val) noexcept {

Buffer.hpp

@@ -8,7 +8,7 @@
  */
 
 #pragma once
-#include <vector>
+#include <deque>
 #include <sstream>
 #include <exception>
 
@@ -17,7 +17,6 @@ struct BufferOverflow : public std::exception {};
 class Buffer {
 public:
     Buffer() noexcept;
-    Buffer(const std::vector<unsigned char>&) noexcept;
 
     void clear() noexcept;
     void write(char * str, long length) noexcept;
@@ -102,5 +101,5 @@ class Buffer {
 
     ~Buffer();
 private:
-    std::vector<unsigned char> buffer;
+    std::deque<unsigned char> buffer;
 };