GetRepositoryDynamicReturnTypeExtension: improved return type when argument is not recognized

Author: pepakriz

src/Type/Doctrine/GetRepositoryDynamicReturnTypeExtension.php

@@ -9,7 +9,6 @@
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\Generic\GenericClassStringType;
 use PHPStan\Type\Generic\GenericObjectType;
-use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeWithClassName;
@@ -60,12 +59,16 @@ public function getTypeFromMethodCall(
 		} elseif ($argType instanceof GenericClassStringType) {
 			$classType = $argType->getGenericType();
 			if (!$classType instanceof TypeWithClassName) {
-				return new MixedType();
+				return ParametersAcceptorSelector::selectSingle(
+					$methodReflection->getVariants()
+				)->getReturnType();
 			}
 
 			$objectName = $classType->getClassName();
 		} else {
-			return new MixedType();
+			return ParametersAcceptorSelector::selectSingle(
+				$methodReflection->getVariants()
+			)->getReturnType();
 		}
 
 		$repositoryClass = $this->metadataResolver->getRepositoryClass($objectName);

tests/DoctrineIntegration/ORM/data/entityManagerDynamicReturn-2.json

@@ -13,5 +13,10 @@
         "message": "Call to an undefined method PHPStan\\DoctrineIntegration\\ORM\\EntityManagerDynamicReturn\\MyEntity::doSomethingElse().",
         "line": 54,
         "ignorable": true
+    },
+    {
+        "message": "Call to an undefined method Doctrine\\Persistence\\ObjectRepository<T>::unknownMethod().",
+        "line": 64,
+        "ignorable": true
     }
 ]

tests/DoctrineIntegration/ORM/data/entityManagerDynamicReturn.php

@@ -53,6 +53,16 @@ public function getPartialReferenceDynamicType(): void
 		$test->doSomething();
 		$test->doSomethingElse();
 	}
+
+	/**
+	 * @param class-string $entityName
+	 */
+	public function doSomethingWithRepository(string $entityName): void
+	{
+		$repository = $this->entityManager->getRepository($entityName);
+		$repository->getClassName();
+		$repository->unknownMethod();
+	}
 }
 
 /**