use Trinary

Author: staabm

src/Rules/PHPUnit/DataProviderHelper.php

@@ -65,7 +65,7 @@ public function getDataProviderMethods(
 	{
 		yield from $this->yieldDataProviderAnnotations($testMethod, $scope, $classReflection);
 
-		if (!$this->PHPUnitVersion->supportsDataProviderAttribute()) {
+		if (!$this->PHPUnitVersion->supportsDataProviderAttribute()->yes()) {
 			return;
 		}
 
@@ -156,7 +156,11 @@ public function processDataProvider(
 				->build();
 		}
 
-		if ($deprecationRulesInstalled && $this->PHPUnitVersion->requiresStaticDataProviders() && !$dataProviderMethodReflection->isStatic()) {
+		if (
+			$deprecationRulesInstalled
+			&& $this->PHPUnitVersion->requiresStaticDataProviders()->yes()
+			&& !$dataProviderMethodReflection->isStatic()
+		) {
 			$errorBuilder = RuleErrorBuilder::message(sprintf(
 				'@dataProvider %s related method must be static in PHPUnit 10 and newer.',
 				$dataProviderValue,

src/Rules/PHPUnit/PHPUnitVersion.php

@@ -2,6 +2,8 @@
 
 namespace PHPStan\Rules\PHPUnit;
 
+use PHPStan\TrinaryLogic;
+
 class PHPUnitVersion
 {
 
@@ -12,19 +14,28 @@ public function __construct(?int $majorVersion)
 		$this->majorVersion = $majorVersion;
 	}
 
-	public function supportsDataProviderAttribute(): bool
+	public function supportsDataProviderAttribute(): TrinaryLogic
 	{
-		return $this->majorVersion !== null && $this->majorVersion >= 10;
+		if ($this->majorVersion === null) {
+			return TrinaryLogic::createMaybe();
+		}
+		return TrinaryLogic::createFromBoolean($this->majorVersion >= 10);
 	}
 
-	public function supportsTestAttribute(): bool
+	public function supportsTestAttribute(): TrinaryLogic
 	{
-		return $this->majorVersion !== null && $this->majorVersion >= 10;
+		if ($this->majorVersion === null) {
+			return TrinaryLogic::createMaybe();
+		}
+		return TrinaryLogic::createFromBoolean($this->majorVersion >= 10);
 	}
 
-	public function requiresStaticDataProviders(): bool
+	public function requiresStaticDataProviders(): TrinaryLogic
 	{
-		return $this->majorVersion !== null && $this->majorVersion >= 10;
+		if ($this->majorVersion === null) {
+			return TrinaryLogic::createMaybe();
+		}
+		return TrinaryLogic::createFromBoolean($this->majorVersion >= 10);
 	}
 
 }

src/Rules/PHPUnit/TestMethodsHelper.php

@@ -63,7 +63,7 @@ public function getTestMethods(ClassReflection $classReflection, Scope $scope):
 				}
 			}
 
-			if (!$this->PHPUnitVersion->supportsTestAttribute()) {
+			if ($this->PHPUnitVersion->supportsTestAttribute()->no()) {
 				continue;
 			}