move is-test-case check into TestMethodsHelper

Author: staabm

src/Rules/PHPUnit/DataProviderDataRule.php

@@ -8,7 +8,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
-use PHPUnit\Framework\TestCase;
 use function array_slice;
 use function count;
 use function max;
@@ -62,10 +61,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$method = $scope->getFunction();
 		$classReflection = $scope->getClassReflection();
-		if (
-			$classReflection === null
-			|| !$classReflection->is(TestCase::class)
-		) {
+		if ($classReflection === null) {
 			return [];
 		}
 

src/Rules/PHPUnit/TestMethodsHelper.php

@@ -6,6 +6,7 @@
 use PHPStan\PhpDoc\ResolvedPhpDocBlock;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Type\FileTypeMapper;
+use PHPUnit\Framework\TestCase;
 use ReflectionMethod;
 use function str_starts_with;
 use function strtolower;
@@ -31,6 +32,10 @@ public function __construct(
 	 */
 	public function getTestMethods(ClassReflection $classReflection, Scope $scope): array
 	{
+		if (!$classReflection->is(TestCase::class)) {
+			return [];
+		}
+
 		$testMethods = [];
 		foreach ($classReflection->getNativeReflection()->getMethods() as $reflectionMethod) {
 			if (!$reflectionMethod->isPublic()) {

tests/Type/PHPUnit/DataProviderReturnTypeIgnoreExtensionTest.php

@@ -14,7 +14,7 @@ protected function getRule(): Rule
 	{
 		/** @phpstan-ignore phpstanApi.classConstant */
 		$rule = self::getContainer()->getByType(MissingMethodReturnTypehintRule::class);
-		
+
 		return $rule;
 	}