refactor

Author: staabm

tests/Rules/PHPUnit/DataProviderDeclarationRuleTest.php

@@ -29,81 +29,81 @@ protected function getRule(): Rule
 		);
 	}
 
-	public function testRule(): void
-	{
-		$this->phpunitVersion = 10;
-
-		$this->analyse([__DIR__ . '/data/data-provider-declaration.php'], [
-			[
-				'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
-				16,
-			],
-			[
-				'@dataProvider provideQux related method must be static in PHPUnit 10 and newer.',
-				16,
-			],
-			[
-				'@dataProvider provideQuux related method must be public.',
-				16,
-			],
-			[
-				'@dataProvider provideNonExisting related method not found.',
-				70,
-			],
-			[
-				'@dataProvider NonExisting::provideNonExisting related class not found.',
-				70,
-			],
-			[
-				'@dataProvider provideNonExisting related method not found.',
-				85,
-			],
-			[
-				'@dataProvider provideNonExisting2 related method not found.',
-				86,
-			],
-			[
-				'@dataProvider ExampleTestCase\\BarTestCase::providetootherclass related method is used with incorrect case: provideToOtherClass.',
-				87,
-			],
-			[
-				'@dataProvider ExampleTestCase\\BarTestCase::providetootherclass related method is used with incorrect case: provideToOtherClass.',
-				88,
-			],
-		]);
-	}
-
 	/**
 	 * @dataProvider provideVersion
 	 */
-	public function testRulePhpUnit9orUnknown(?int $version): void
+	public function testRule(?int $version): void
 	{
 		$this->phpunitVersion = $version;
 
-		$this->analyse([__DIR__ . '/data/data-provider-declaration.php'], [
-			[
-				'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
-				16,
-			],
-			[
-				'@dataProvider provideQuux related method must be public.',
-				16,
-			],
-			[
-				'@dataProvider provideNonExisting related method not found.',
-				70,
-			],
-			[
-				'@dataProvider NonExisting::provideNonExisting related class not found.',
-				70,
-			],
-		]);
+		if ($version === 10) {
+			$errors = [
+				[
+					'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
+					16,
+				],
+				[
+					'@dataProvider provideQux related method must be static in PHPUnit 10 and newer.',
+					16,
+				],
+				[
+					'@dataProvider provideQuux related method must be public.',
+					16,
+				],
+				[
+					'@dataProvider provideNonExisting related method not found.',
+					70,
+				],
+				[
+					'@dataProvider NonExisting::provideNonExisting related class not found.',
+					70,
+				],
+				[
+					'@dataProvider provideNonExisting related method not found.',
+					85,
+				],
+				[
+					'@dataProvider provideNonExisting2 related method not found.',
+					86,
+				],
+				[
+					'@dataProvider ExampleTestCase\\BarTestCase::providetootherclass related method is used with incorrect case: provideToOtherClass.',
+					87,
+				],
+				[
+					'@dataProvider ExampleTestCase\\BarTestCase::providetootherclass related method is used with incorrect case: provideToOtherClass.',
+					88,
+				],
+			];
+		} else {
+			$errors = [
+				[
+					'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
+					16,
+				],
+				[
+					'@dataProvider provideQuux related method must be public.',
+					16,
+				],
+				[
+					'@dataProvider provideNonExisting related method not found.',
+					70,
+				],
+				[
+					'@dataProvider NonExisting::provideNonExisting related class not found.',
+					70,
+				],
+			];
+		}
+
+		$this->analyse([__DIR__ . '/data/data-provider-declaration.php'], $errors);
 	}
 
 	static public function provideVersion(): iterable
 	{
-		yield [9];
 		yield [null];
+		yield [9];
+		yield [10];
 	}
 
 	public function testFixDataProviderStatic(): void