Fix test

ondrejmirtes · ondrejmirtes · commit 4f635e7ffe1b · 2025-10-10T23:03:24.000+02:00
diff --git a/tests/PHPStan/Type/SimultaneousTypeTraverserTest.php b/tests/PHPStan/Type/SimultaneousTypeTraverserTest.php
@@ -92,10 +92,10 @@ public function testChangeIntegerIntoString(Type $left, Type $right, string $exp
 	public static function dataDescriptionBased(): iterable
 	{
 		$chooseScalarSubtype = static function (Type $left, Type $right, callable $traverse): Type {
-			if (!$left->isScalar()->yes()) {
+			if (!$left->isScalar()->yes() || $left instanceof BenevolentUnionType) {
 				return $traverse($left, $right);
 			}
-			if (!$right->isScalar()->yes()) {
+			if (!$right->isScalar()->yes() || $right instanceof BenevolentUnionType) {
 				return $traverse($left, $right);
 			}
 			if (!$left->isSuperTypeOf($right)->yes()) {

Original file line number	Diff line number	Diff line change
`@@ -92,10 +92,10 @@ public function testChangeIntegerIntoString(Type $left, Type $right, string $exp`
`92`	`92`	`public static function dataDescriptionBased(): iterable`
`93`	`93`	`{`
`94`	`94`	`$chooseScalarSubtype = static function (Type $left, Type $right, callable $traverse): Type {`
`95`		`- if (!$left->isScalar()->yes()) {`
	`95`	`+ if (!$left->isScalar()->yes() \|\| $left instanceof BenevolentUnionType) {`
`96`	`96`	`return $traverse($left, $right);`
`97`	`97`	`}`
`98`		`- if (!$right->isScalar()->yes()) {`
	`98`	`+ if (!$right->isScalar()->yes() \|\| $right instanceof BenevolentUnionType) {`
`99`	`99`	`return $traverse($left, $right);`
`100`	`100`	`}`
`101`	`101`	`if (!$left->isSuperTypeOf($right)->yes()) {`