unit testing and fixes

Author: Christian Blanquera

phpunit.xml

@@ -30,7 +30,7 @@
       <file>test/Profiler/InspectorTrait.php</file>
       <file>test/Profiler/LoggerTrait.php</file>
     </testsuite>
-      <testsuite name="Event Test Suite">
+    <testsuite name="Event Test Suite">
       <file>test/Event/EventEmitter.php</file>
       <file>test/Event/EventObserver.php</file>
       <file>test/Event/EventTrait.php</file>
@@ -76,6 +76,7 @@
       <file>test/IO/Request/StageTrait.php</file>
       <file>test/IO/Response/ContentTrait.php</file>
       <file>test/IO/Response/HeaderTrait.php</file>
+      <file>test/IO/Response/PageTrait.php</file>
       <file>test/IO/Response/ResponseTrait.php</file>
       <file>test/IO/Response/RestTrait.php</file>
       <file>test/IO/Response/StatusTrait.php</file>
@@ -114,6 +115,10 @@
       <file>test/Async/Promise.php</file>
       <file>test/Async/AsyncTrait.php</file>
     </testsuite>
+    <testsuite name="OAuth Test Suite">
+      <file>test/OAuth/OAuth1.php</file>
+      <file>test/OAuth/OAuth2.php</file>
+    </testsuite>
   </testsuites>
 
   <coverage processUncoveredFiles="false" pathCoverage="true">
@@ -146,6 +151,7 @@
       <file>src/Async/map/noop.php</file>
       <file>src/Async/map/shutdown.php</file>
       <file>src/Async/map/socket.php</file>
+      <file>src/Terminal/map.php</file>
     </exclude>
   </coverage>
 </phpunit>

src/Async/Promise.php

@@ -444,6 +444,7 @@ protected function settle(int $state, SplQueue $queue = null): bool
 
     //if the return value is a Promise
     if ($value instanceof Promise) {
+      // @codeCoverageIgnoreStart
       //we need to wait for the value before continuing
       $fulfill = function ($value) use ($queue) {
         //set the value
@@ -458,6 +459,7 @@ protected function settle(int $state, SplQueue $queue = null): bool
         //continue to settle
         $this->settle(static::STATUS_REJECTED, $queue);
       };
+      // @codeCoverageIgnoreEnd
 
       $value->then($fulfill, $reject);
 

src/Curl/CurlHandler.php

@@ -154,9 +154,11 @@ public function __call($name, $args)
    */
   public function __construct(Closure $map = null)
   {
+    // @codeCoverageIgnoreStart
     if (is_null(self::$mapCache)) {
       self::$mapCache = include(__DIR__ . '/map.php');
     }
+    // @codeCoverageIgnoreEnd
 
     $this->map = self::$mapCache;
 

src/Curl/Rest.php

@@ -112,8 +112,10 @@ public function __call(string $name, array $args)
       return $this;
     }
 
+    // @codeCoverageIgnoreStart
     //let the parent handle the rest
     return parent::__call($name, $args);
+    // @codeCoverageIgnoreEnd
   }
 
   /**
@@ -309,9 +311,11 @@ public function send(string $method, string $path)
       case CurlHandler::ENCODE_JSON:
         $response = $request->getJsonResponse(); // get the json response
         break;
+      // @codeCoverageIgnoreStart
       case CurlHandler::ENCODE_XML:
         $response = $request->getSimpleXmlResponse(); // get the xml response
         break;
+      // @codeCoverageIgnoreEnd
       case CurlHandler::ENCODE_RAW:
       default:
         $response = $request->getResponse(); // get the raw response

src/Data/DotTrait.php

@@ -31,10 +31,6 @@ public function getDot(string $notation, string $separator = '.')
   {
     $args = explode($separator, $notation);
 
-    if (count($args) == 0) {
-      return null;
-    }
-
     $last = array_pop($args);
     $pointer = &$this->data;
 
@@ -65,10 +61,6 @@ public function isDot(string $notation, string $separator = '.'): bool
   {
     $args = explode($separator, $notation);
 
-    if (count($args) == 0) {
-      return false;
-    }
-
     $last = array_pop($args);
 
     $pointer = &$this->data;
@@ -101,10 +93,6 @@ public function removeDot(string $notation, string $separator = '.')
   {
     $args = explode($separator, $notation);
 
-    if (count($args) === 0) {
-      return $this;
-    }
-
     $last = array_pop($args);
 
     $pointer = &$this->data;
@@ -137,10 +125,6 @@ public function setDot(string $notation, $value, string $separator = '.')
   {
     $args = explode($separator, $notation);
 
-    if (count($args) === 0) {
-      return $this;
-    }
-
     $last = array_pop($args);
 
     $pointer = &$this->data;

src/Event/EventEmitter.php

@@ -79,10 +79,12 @@ public function emit(string $event, ...$args): EventInterface
     foreach ($matches as $match) {
       $event = $match['pattern'];
 
+      // @codeCoverageIgnoreStart
       //if no direct observers
       if (!isset($this->observers[$event])) {
         continue;
       }
+      // @codeCoverageIgnoreEnd
 
       //add args on to match
       $match['args'] = $args;
@@ -293,12 +295,6 @@ protected function unbindByCallback(callable $callback): EventInterface
    */
   protected function unbindByEvent(string $event, callable $callback): EventInterface
   {
-    //if event isn't set
-    if (!isset($this->observers[$event])) {
-      //do nothing
-      return $this;
-    }
-
     //'foobar' => array(
     foreach ($this->observers[$event] as $i => $observer) {
       //0 => callback

src/Http/HttpDispatcher.php

@@ -80,7 +80,7 @@ public function __construct(Closure $output = null, Closure $redirect = null)
    * Starts to process the request
    *
    * @param ResponseInterface $response The response object to evaluate
-   * @param bool        $emulate  If you really want it to echo (for testing)
+   * @param bool              $emulate  If you really want it to echo (for testing)
    *
    * @return array with request and response inside
    */
@@ -116,7 +116,7 @@ public function dispatch(ResponseInterface $response, bool $emulate = false)
    * output. Then of course, output it
    *
    * @param ResponseInterface $response The response object to evaluate
-   * @param bool        $emulate  If you really want it to echo (for testing)
+   * @param bool              $emulate  If you really want it to echo (for testing)
    *
    * @return HttpHandler
    */
@@ -145,9 +145,9 @@ public function output(ResponseInterface $response, bool $emulate = false)
   /**
    * Browser redirect
    *
-   * @param *string $path  Where to redirect to
-   * @param bool  $force Whether if you want to exit immediately
-   * @param bool  $emulate  If you really want it to redirect (for testing)
+   * @param *string $path    Where to redirect to
+   * @param bool    $force   Whether if you want to exit immediately
+   * @param bool    $emulate If you really want it to redirect (for testing)
    *
    * @return HttpDispatcher
    */

src/Http/HttpTrait.php

@@ -102,13 +102,15 @@ protected function hasRedirect(): bool
       return true;
     }
 
+    // @codeCoverageIgnoreStart
     //we need to also check the PHP headers
     foreach (headers_list() as $header) {
       //if there was a redirect set
       if (strpos(strtolower($header), 'location:') === 0) {
         return true;
       }
     }
+    // @codeCoverageIgnoreEnd
 
     //no redirect was found
     return false;

src/Http/Router.php

@@ -77,11 +77,6 @@ public function route(
     callable $callback,
     int $priority = 0
   ): RouterInterface {
-    //hard requirement
-    if (!is_callable($callback)) {
-      throw HttpException::forInvalidRouteCallback();
-    }
-
     if (strtoupper($method) === 'ALL') {
       $method = '[a-zA-Z0-9]+';
     }

src/I18n/Timezone.php

@@ -287,7 +287,9 @@ public function toRelative(
       return $difference . ' ' . $relative . ($difference === 1 ? '' : 's') . $suffix;
     }
 
+    // @codeCoverageIgnoreStart
     return date($default, $this->time);
+    // @codeCoverageIgnoreEnd
   }
 
   /**
@@ -408,7 +410,9 @@ protected function getOffsetFromUtc(string $zone)
         return ($hour+$minute) * ($add?1:-1);
     }
 
+    // @codeCoverageIgnoreStart
     return 0;
+    // @codeCoverageIgnoreEnd
   }
 
   /**