From a46c69c111de9f2e979a97cb06f7fa87ea6fd929 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 20 Dec 2022 11:46:25 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- stock_visualizer/utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/stock_visualizer/utils.py b/stock_visualizer/utils.py index 3fed7c6..f18d504 100644 --- a/stock_visualizer/utils.py +++ b/stock_visualizer/utils.py @@ -30,7 +30,26 @@ def check_download(data_dir='./data'): if os.path.exists(extracted_dir): shutil.rmtree(extracted_dir) with tarfile.open(file_path) as tar: - tar.extractall(path=data_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=data_dir) return extracted_dir