-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
We currently hardcode expected URLs for Open Tree resolution in our tests:
phyx.js/test/scripts/resolve.js
Lines 64 to 78 in d3623e3
| expect(resultObj.Alligatoridae[0].resolved).to.include({ | |
| '@id': 'https://tree.opentreeoflife.org/opentree/argus/opentree12.3@ott195670', | |
| label: 'Alligatoridae', | |
| }); | |
| expect(resultObj.Alligatorinae[0].resolved).to.include({ | |
| '@id': 'https://tree.opentreeoflife.org/opentree/argus/opentree12.3@ott151255', | |
| label: 'Alligatorinae', | |
| }); | |
| expect(resultObj.Crocodylidae[0].resolved).to.include({ | |
| '@id': 'https://tree.opentreeoflife.org/opentree/argus/opentree12.3@ott1092501', | |
| label: 'Longirostres', | |
| }); | |
| expect(resultObj.Diplocynodontinae[0]).to.include({ | |
| error: 'no_mrca_found:400', | |
| }); |
This is fine until the Open Tree of Life synthetic tree version, which is part of the URL, changes. Unfortunately, I don't see a way of requesting a node on a particular version of the synthetic tree. Therefore, we should change this test to work with whichever version of the Open Tree synthetic tree is returned. We will still need to change the node IDs if they change, but since those are tied to their Open Tree Taxonomy ID (e.g. Longirostris, which is ott1092501), they shouldn't change between releases unless the taxonomy has changed dramatically.
Metadata
Metadata
Assignees
Labels
No labels