Skip to content

Picketlink performance is too bad due to have unresonable lock. #165

@wzhx78

Description

@wzhx78

when we test picketlink performance, we found the picketlink performance is very bad due to each of process have global lock in the code. e.g org.picketlink.identity.federation.web.process.SAMLHandlerChainProcessor. ServiceProviderBaseProcessor and org/picketlink/identity/federation/bindings/tomcat/idp/AbstractIDPValve. but we check the handler is thread safe, so the lock is unreasonable. we can remove this lock or change the hanlder not singletone.

we had tried to fix by our self. after remove unreasonable lock, the TPS will back to 456, one TPS include one login and one global logout.

please check our gist.

https://gist.github.com/wzhx78/5418959

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions