Skip to content

[Bug] Not all directories in models are symlinked to drive directory #14

@brnl

Description

@brnl

I stumbled upon a bug that not all directories in ComfyUI are symlinked to the drive directory:

$ ls -l ~/pinokio/api/comfy.git/app/models
total 60
lrwxrwxrwx. 1 user user  57 28 jul 05:19 checkpoints -> ../../../../drive/drives/peers/d0000000000000/checkpoints
lrwxrwxrwx. 1 user user  50 28 jul 05:19 clip -> ../../../../drive/drives/peers/d0000000000000/clip
lrwxrwxrwx. 1 user user  57 28 jul 05:19 clip_vision -> ../../../../drive/drives/peers/d0000000000000/clip_vision
lrwxrwxrwx. 1 user user  53 28 jul 05:19 configs -> ../../../../drive/drives/peers/d0000000000000/configs
lrwxrwxrwx. 1 user user  56 28 jul 05:19 controlnet -> ../../../../drive/drives/peers/d0000000000000/controlnet
lrwxrwxrwx. 1 user user  55 28 jul 05:19 diffusers -> ../../../../drive/drives/peers/d0000000000000/diffusers
drwxr-xr-x. 1 user user 180 28 jul 17:09 diffusion_models
lrwxrwxrwx. 1 user user  56 28 jul 05:19 embeddings -> ../../../../drive/drives/peers/d0000000000000/embeddings
lrwxrwxrwx. 1 user user  52 28 jul 05:19 gligen -> ../../../../drive/drives/peers/d0000000000000/gligen
lrwxrwxrwx. 1 user user  59 28 jul 05:19 hypernetworks -> ../../../../drive/drives/peers/d0000000000000/hypernetworks
lrwxrwxrwx. 1 user user  51 28 jul 05:19 loras -> ../../../../drive/drives/peers/d0000000000000/loras
lrwxrwxrwx. 1 user user  56 28 jul 05:19 photomaker -> ../../../../drive/drives/peers/d0000000000000/photomaker
lrwxrwxrwx. 1 user user  58 28 jul 05:19 style_models -> ../../../../drive/drives/peers/d0000000000000/style_models
drwxr-xr-x. 1 user user  54 28 jul 05:16 text_encoders
lrwxrwxrwx. 1 user user  50 28 jul 05:19 unet -> ../../../../drive/drives/peers/d0000000000000/unet
lrwxrwxrwx. 1 user user  60 28 jul 05:19 upscale_models -> ../../../../drive/drives/peers/d0000000000000/upscale_models
lrwxrwxrwx. 1 user user  49 28 jul 05:19 vae -> ../../../../drive/drives/peers/d0000000000000/vae
drwxr-xr-x. 1 user user  96 28 jul 05:16 vae_approx

$ ls -l ~/pinokio/drive/drives/peers/d0000000000000
total 0
drwxr-xr-x. 1 user user  736 28 jul 18:10 checkpoints
drwxr-xr-x. 1 user user  446 28 jul 17:48 clip
drwxr-xr-x. 1 user user   54 28 jul 05:19 clip_vision
drwxr-xr-x. 1 user user  512 28 jul 18:06 configs
drwxr-xr-x. 1 user user  184 28 jul 18:10 controlnet
drwxr-xr-x. 1 user user   50 28 jul 14:58 diffusers
drwxr-xr-x. 1 user user   98 28 jul 05:19 embeddings
drwxr-xr-x. 1 user user   44 28 jul 05:19 gligen
drwxr-xr-x. 1 user user   44 28 jul 05:19 hypernetworks
drwxr-xr-x. 1 user user  134 28 jul 14:54 loras
drwxr-xr-x. 1 user user 2628 28 jul 18:54 output
drwxr-xr-x. 1 user user   52 28 jul 05:19 photomaker
drwxr-xr-x. 1 user user   48 28 jul 05:19 style_models
drwxr-xr-x. 1 user user   38 28 jul 05:19 unet
drwxr-xr-x. 1 user user   80 28 jul 05:19 upscale_models
drwxr-xr-x. 1 user user   96 28 jul 16:57 vae
drwxr-xr-x. 1 user user    0 28 jul 05:19 vae_approx

To fix this, I think we need to update the install.js:

// ...
    {
      "method": "fs.link",
      "params": {
        "drive": {
          "checkpoints": "app/models/checkpoints",
          "clip_vision": "app/models/clip_vision",
          "clip": "app/models/clip",
          "configs": "app/models/configs",
          "controlnet": "app/models/controlnet",
          "diffusers": "app/models/diffusers",
          "diffusion_models": "app/models/diffusion_models",  // New
          "embeddings": "app/models/embeddings",
          "gligen": "app/models/gligen",
          "hypernetworks": "app/models/hypernetworks",
          "loras": "app/models/loras",
          "photomaker": "app/models/photomaker",
          "style_models": "app/models/style_models",
          "text_encoders": "app/models/text_encoders",        // New
          "unet": "app/models/unet",
          "upscale_models": "app/models/upscale_models",
          "vae_approx": "app/models/vae_approx",              // Fixed: this was app/models/VAE-approx
          "vae": "app/models/vae"
        },
// ...

I will make a PR to fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions