-
Notifications
You must be signed in to change notification settings - Fork 192
Description
In the last months, Pion has acquired large numbers of new linters that dramatically increase the amount of work required to submit a PR. What should be a three-minute job now requires multiple back-and-forths between the command line and the github interface while we make random wording changes until the linters are satisfied. Sacrificing an immaculate lamb over the keyboard helps, but doesn't completely solve the issue.
I have already mentioned the nakedret (pion/webrtc#3331) and nlreturn (pion/webrtc#3334) linters, each of which caused me additional round-trips while I was making minor changes to Pion.
The first commit in #862 consistently uses the name a to refer to the agent. Unfortunately the varnamelen linter is opposed to consistency, and requires using a different name if a function is longer than some arbitrary threshold.
Please remove the varnamelen linter.