-
Notifications
You must be signed in to change notification settings - Fork 44
Description
EBPatcher and CoilSnake's patch applying code don't always generate a matching result.
As one example of this, consider a hack that expands the game to 48 megabits, like Mother 2 Deluxe 2.0. The IPS component of its patch doesn't include any writes to file address 00FFD5 or 00FFD7, for some reason. EBPatcher keeps these bytes the same, but CoilSnake changes these bytes, as if by first expanding the ROM to 48 megabits using the relevant menu option in CoilSnake and then applying the patch:
It's not good to have a patch that can be applied in two different ways. Thankfully it is only two ways (the result didn't change
(Separately from this, the patch should probably include those byte changes in the first place... There may be one or many other obscure issues lurking. The EBP code is kind of hard to follow in the first place because a lot of important logic is in coilsnake.ui.common rather than coilsnake.model.eb.ebp.)
