diff --git a/.golangci.yml b/.golangci.yml index 827ca9c..afb3fa6 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -13,6 +13,8 @@ linters: - noctx - unconvert settings: + errcheck: + check-blank: true govet: enable: - unusedwrite @@ -25,4 +27,4 @@ linters: rules: - linters: - gosec - text: G115 \ No newline at end of file + text: G115 diff --git a/cmd/airbyte-source/check.go b/cmd/airbyte-source/check.go index 91ba09d..b223432 100644 --- a/cmd/airbyte-source/check.go +++ b/cmd/airbyte-source/check.go @@ -49,7 +49,10 @@ func CheckCommand(ch *Helper) *cobra.Command { } }() - cs, _ := checkConnectionStatus(ch.Database, psc) + cs, err := checkConnectionStatus(ch.Database, psc) + if err != nil { + fmt.Fprintf(cmd.ErrOrStderr(), "Unable to check connection status for PlanetScale Database, failed with %v", err) + } ch.Logger.ConnectionStatus(cs) }, } @@ -71,7 +74,6 @@ func parseSource(reader FileReader, configFilePath string) (internal.PlanetScale } func checkConnectionStatus(database internal.PlanetScaleDatabase, psc internal.PlanetScaleSource) (internal.ConnectionStatus, error) { - if err := database.CanConnect(context.Background(), psc); err != nil { return internal.ConnectionStatus{ Status: "FAILED", diff --git a/cmd/internal/planetscale_connection.go b/cmd/internal/planetscale_connection.go index ed5e273..f85ad0e 100644 --- a/cmd/internal/planetscale_connection.go +++ b/cmd/internal/planetscale_connection.go @@ -101,11 +101,14 @@ func (psc PlanetScaleSource) GetInitialState(keyspaceOrDatabase string, shards [ } } - cursor, _ := TableCursorToSerializedCursor(&psdbconnect.TableCursor{ + cursor, err := TableCursorToSerializedCursor(&psdbconnect.TableCursor{ Shard: shard, Keyspace: keyspaceOrDatabase, Position: position, }) + if err != nil { + return shardCursors, fmt.Errorf("table cursor to serialized cursor: %w", err) + } shardCursors.Shards[shard] = cursor }