Merge pull request #343 from platanus/webpacker-tests-refactor

Webpacker tests refactor

Author: ldlsegovia

.circleci/config.yml

@@ -0,0 +1,73 @@
+version: 2.1
+orbs:
+  ruby: circleci/ruby@0.1.2
+  browser-tools: circleci/browser-tools@1.1.3
+jobs:
+  test:
+    parameters:
+      ruby-version:
+        type: string
+    docker:
+      - image: circleci/ruby:<< parameters.ruby-version >>-node
+        environment:
+          RAILS_ENV: test
+          NODE_ENV: test
+          BUNDLE_PATH: vendor/bundle
+          SPROCKETS: false
+    executor: ruby/default
+    steps:
+      - checkout
+      - browser-tools/install-chrome
+      - browser-tools/install-chromedriver
+      - restore_cache:
+          keys:
+          - bundler-dependencies-{{ checksum "Gemfile.lock" }}
+          - bundler-dependencies-
+      - run:
+          name: Install bundle dependencies
+          command: |
+            BUNDLER_VERSION=$(cat Gemfile.lock | tail -1 | tr -d " ")
+            gem install bundler:$BUNDLER_VERSION
+            bundle _$(echo $BUNDLER_VERSION)_ install
+      - save_cache:
+          key: bundler-dependencies-{{ checksum "Gemfile.lock" }}
+          paths:
+            - vendor/bundle
+      - run:
+          name: Setup database
+          command: (cd spec/dummy && bundle exec rake db:setup)
+      - run:
+          name: Prepare Assets
+          command: |
+            bundle exec rake prepare_assets
+            (cd spec/dummy && bundle exec rake webpacker:compile)
+      - run:
+          name: Utils Tests
+          command: |
+            RSPEC_JUNIT_ARGS="-r rspec_junit_formatter -f RspecJunitFormatter -o test_results/utils-rspec.xml"
+            RSPEC_FORMAT_ARGS="-f progress --no-color -p 10"
+            bundle exec rspec ./spec/lib $RSPEC_FORMAT_ARGS $RSPEC_JUNIT_ARGS
+      - run:
+          name: Run Webpack Tests
+          command: |
+            RSPEC_JUNIT_ARGS="-r rspec_junit_formatter -f RspecJunitFormatter -o test_results/webpack-rspec.xml"
+            RSPEC_FORMAT_ARGS="-f progress --no-color -p 10"
+            export SPROCKETS=false
+            bundle exec rspec ./spec/features $RSPEC_FORMAT_ARGS $RSPEC_JUNIT_ARGS
+      - run:
+          name: Run Sprockets Tests
+          command: |
+            RSPEC_JUNIT_ARGS="-r rspec_junit_formatter -f RspecJunitFormatter -o test_results/sprockets-rspec.xml"
+            RSPEC_FORMAT_ARGS="-f progress --no-color -p 10"
+            export SPROCKETS=true
+            bundle exec rspec ./spec/features $RSPEC_FORMAT_ARGS $RSPEC_JUNIT_ARGS
+      - store_test_results:
+          path: test_results
+workflows:
+  version: 2
+  test:
+    jobs:
+      - test:
+          matrix:
+            parameters:
+              ruby-version: ["2.5", "2.6", "2.7"]

.gitignore

@@ -7,10 +7,12 @@ spec/dummy/log/*.log
 spec/dummy/tmp/
 spec/dummy/.sass-cache
 spec/dummy/public/system
+spec/dummy/public/packs-test
+spec/dummy/public/packs
 .gem
 .gemtags
 .tags
 .tags_sorted_by_file
 vendor/bundle
 node_modules
-src
+src

.rspec

@@ -1,3 +1,2 @@
 --require spec_helper
 --color
---format=doc

.ruby-version

@@ -1 +1 @@
-2.7.0
+2.7

.travis.yml

@@ -13,3 +13,6 @@ gemspec
 # To use debugger
 # gem "debugger"
 gem "activeadmin"
+gem "mimemagic", github: "mimemagicrb/mimemagic", ref: "01f92d86d15d85cfd0f20dabd025dcbd36a8a60f"
+
+gem "webpacker", "~> 5.0", require: ENV["SPROCKETS"] != "true"

Gemfile

@@ -1,3 +1,10 @@
+GIT
+  remote: https://github.com/mimemagicrb/mimemagic.git
+  revision: 01f92d86d15d85cfd0f20dabd025dcbd36a8a60f
+  ref: 01f92d86d15d85cfd0f20dabd025dcbd36a8a60f
+  specs:
+    mimemagic (0.3.5)
+
 PATH
   remote: .
   specs:
@@ -163,7 +170,6 @@ GEM
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2019.1009)
-    mimemagic (0.3.4)
     mini_mime (1.0.2)
     mini_portile2 (2.4.0)
     minitest (5.14.0)
@@ -193,9 +199,11 @@ GEM
       pry (>= 0.10.4)
     psych (3.1.0)
     public_suffix (4.0.3)
-    puma (4.3.5)
+    puma (5.3.1)
       nio4r (~> 2.0)
     rack (2.2.2)
+    rack-proxy (0.6.5)
+      rack
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rails (5.2.4.1)
@@ -258,6 +266,8 @@ GEM
       rspec-mocks (~> 3.9.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
+    rspec_junit_formatter (0.4.1)
+      rspec-core (>= 2, < 4, != 2.12.0)
     rubocop (0.65.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
@@ -280,6 +290,7 @@ GEM
     selenium-webdriver (3.142.7)
       childprocess (>= 0.5, < 4.0)
       rubyzip (>= 1.2.2)
+    semantic_range (3.0.0)
     shellany (0.0.1)
     shoulda-matchers (4.2.0)
       activesupport (>= 4.2.0)
@@ -303,6 +314,11 @@ GEM
       nokogiri (~> 1.6)
       rubyzip (>= 1.3.0)
       selenium-webdriver (>= 3.0, < 4.0)
+    webpacker (5.3.0)
+      activesupport (>= 5.2)
+      rack-proxy (>= 0.6.1)
+      railties (>= 5.2)
+      semantic_range (>= 2.3.0)
     websocket-driver (0.7.1)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.4)
@@ -325,15 +341,18 @@ DEPENDENCIES
   factory_bot_rails
   guard
   guard-rspec
+  mimemagic!
   paperclip
   pry-rails
   puma
   rails (~> 5.2, >= 5.2.4.1)
   rspec-rails
+  rspec_junit_formatter
   rubocop (~> 0.65.0)
   shoulda-matchers
   sqlite3
   webdrivers
+  webpacker (~> 5.0)
 
 BUNDLED WITH
-   1.17.2
+   2.1.4

Gemfile.lock

@@ -1,6 +1,5 @@
 # ActiveAdmin Addons
 [![Gem Version](https://badge.fury.io/rb/activeadmin_addons.svg)](https://badge.fury.io/rb/activeadmin_addons)
-[![Build Status](https://secure.travis-ci.org/platanus/activeadmin_addons.svg?branch=master)](http://travis-ci.org/platanus/activeadmin_addons)
 
 ActiveAdmin Addons will extend your ActiveAdmin and enable a set of addons you can optionally use to improve the ActiveAdmin UI and make it awesome.
 

README.md

@@ -14,11 +14,33 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
+task :prepare_assets do
+  system "rm -rf spec/dummy/public/packs"
+  system "rm -rf spec/dummy/public/packs-test"
+  system "yarn install"
+  system "yarn build"
+  system "(cd spec/dummy && yarn install)"
+end
+
 task :tests do
-  sh "bin/setup"
-  sh "rspec"
-  sh "bin/setup --use_webpacker"
-  sh "rspec"
+  system "rspec ./spec/lib"
+end
+
+task :sprockets_tests do
+  system "rake prepare_assets"
+  system "export SPROCKETS=true; rspec ./spec/features"
+end
+
+task :webpack_tests do
+  system "rake prepare_assets"
+  system "export SPROCKETS=false; rspec ./spec/features"
+end
+
+task :all_tests do
+  system "rake prepare_assets"
+  system "rake tests"
+  system "export SPROCKETS=true; rspec ./spec/features"
+  system "export SPROCKETS=false; rspec ./spec/features"
 end
 
 Bundler::GemHelper.install_tasks

Rakefile

@@ -37,6 +37,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "puma"
   s.add_development_dependency "rails", "~> 5.2", ">= 5.2.4.1"
   s.add_development_dependency "rspec-rails"
+  s.add_development_dependency "rspec_junit_formatter"
   s.add_development_dependency "rubocop", "~> 0.65.0"
   s.add_development_dependency "shoulda-matchers"
   s.add_development_dependency "sqlite3"