From 7a91be47b2219c977ea1d525a6150024d5158af9 Mon Sep 17 00:00:00 2001 From: Karsten Wade Date: Mon, 21 Apr 2025 10:59:25 -0700 Subject: [PATCH 1/2] Restore favicon to 'latest' version of player-ui.github.io It seems there was an error in building the webpage source for the 'latest' that didn't happen for 'next'. In the case of 'latest' (and therefore how it is seen by default in the world), the favicon call is to `favicon.svg` of the 'type="image/x-icon"', which does not render in the browser (at least, not on Chrome on Linux.) This PR simply reverts (or corrects) that change. I don't know that this PR can be merged to make the change, though, as it's evident these pages are built using an Intuit internal build system (a not uncommon situation -- maintaining an external build service is a PITA, ask me how I know.) If there is something I can do from inside of Intuit now that I'm inside, let me know and also email karsten_wade@intuit.com to point me in the right direction. Happy to do self-service, it's also a chance for me to have a "new contributor to Player"-experience. :grin: --- latest/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/latest/index.html b/latest/index.html index 53dd6eeaa..91d41262a 100644 --- a/latest/index.html +++ b/latest/index.html @@ -1,4 +1,4 @@ - Player | Player \ No newline at end of file + From b22f7fc40fdf488fd231c708bdac025c4186c126 Mon Sep 17 00:00:00 2001 From: Karsten Wade Date: Mon, 21 Apr 2025 11:02:00 -0700 Subject: [PATCH 2/2] Fixing copy-pasta error Oops, I forgot to change the path when I used the `/next/index.html` as reference content. --- latest/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/latest/index.html b/latest/index.html index 91d41262a..761eb22d0 100644 --- a/latest/index.html +++ b/latest/index.html @@ -1,4 +1,4 @@ - Player | Player