Align FlowManager APIs across platforms#805
Open
KVSRoyal wants to merge 3 commits intoplayer-1-dot-zerofrom
Open
Align FlowManager APIs across platforms#805KVSRoyal wants to merge 3 commits intoplayer-1-dot-zerofrom
KVSRoyal wants to merge 3 commits intoplayer-1-dot-zerofrom
Conversation
KVSRoyal
force-pushed
the
flow-manager
branch
3 times, most recently
from
33e9748 to
7f55c8b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## player-1-dot-zero #805 +/- ##
=====================================================
- Coverage 85.90% 85.87% -0.03%
=====================================================
Files 507 507
Lines 22891 23129 +238
Branches 2656 2657 +1
=====================================================
+ Hits 19664 19862 +198
- Misses 2898 2939 +41
+ Partials 329 328 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KVSRoyal
force-pushed
the
flow-manager
branch
from
4249f3b to
9be29a4
Compare
KVSRoyal
commented
Feb 27, 2026
Comment on lines
+12
to
+13
| public class AsyncIterationManager<Item : Any, Result : Any, Data : Any>( | ||
| public val iterator: AsyncIterator<Item, Result, Data>, |
Contributor
Author
There was a problem hiding this comment.
This is public but actually not user-facing, per offline discussions. So no release notes are added for this.
KVSRoyal
force-pushed
the
flow-manager
branch
from
9be29a4 to
ee33a59
Compare
KVSRoyal
force-pushed
the
flow-manager
branch
from
ee33a59 to
06e39f9
Compare
Bundle ReportChanges will decrease total bundle size by 4.58kB (-0.08%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: core/playerAssets Changed:
view changes for bundle: plugins/beacon/coreAssets Changed:
view changes for bundle: plugins/stage-revert-data/coreAssets Changed:
view changes for bundle: plugins/common-types/coreAssets Changed:
view changes for bundle: plugins/common-expressions/coreAssets Changed:
view changes for bundle: react/playerAssets Changed:
view changes for bundle: plugins/metrics/coreAssets Changed:
view changes for bundle: plugins/check-path/coreAssets Changed:
view changes for bundle: plugins/reference-assets/coreAssets Changed:
view changes for bundle: plugins/async-node/coreAssets Changed:
view changes for bundle: plugins/markdown/coreAssets Changed:
|
spentacular
approved these changes
Feb 27, 2026
nancywu1
reviewed
Mar 2, 2026
| A function called to fetch the next flow. If the flow is complete, return `nil`. | ||
| `CompletedState` will be `nil` if it is asking for the first state | ||
| - parameters: | ||
| - state: The `CompletedState` from the previous flow if there was one |
Contributor
There was a problem hiding this comment.
do we need to update this comment
Contributor
Author
There was a problem hiding this comment.
I think it's up to date? Is there anything specific that you think we should update?
Contributor
There was a problem hiding this comment.
oh I meant for changing the parameter name from state to result
sugarmanz
reviewed
Mar 3, 2026
| } | ||
|
|
||
| protected val manager: FlowManager = FlowManager(flows) | ||
| protected val internalManager = AsyncIterationManager(manager) |
Member
There was a problem hiding this comment.
Can we rename AsyncIterationManager to AsyncIterationFlow since we're changing the context of what "manager" represents here? Then we can just rename this to managerFlow instead of internalManager
brocollie08
reviewed
Mar 3, 2026
| } | ||
|
|
||
| protected val manager: FlowManager = FlowManager(flows) | ||
| protected val internalManager = AsyncIterationManager(manager) |
Contributor
There was a problem hiding this comment.
rename this to iterationManager
brocollie08
reviewed
Mar 3, 2026
|
|
||
| /** Generic async iterator that uses some [Result] to determine the next [Item] in the iteration */ | ||
| public interface AsyncIterator<Item : Any, Result : Any> { | ||
| public interface AsyncIterator<Item : Any, Result : Any, Data : Any> { |
Contributor
There was a problem hiding this comment.
This is a breaking change, right?
Contributor
Author
There was a problem hiding this comment.
Yeah. I have some release notes for it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ideally, Player's APIs are consistent on different platforms. This PR better aligns the
FlowManagerAPIs across platforms.What
The updates to the Migration Notes double as the "what" section and Release Notes of this PR.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/A(part of 1.0)Does your PR have any documentation updates?