collaboration opportunity (node-red-contrib-mcprotocol) #5
Description
Hello PLCPeople / Dana?
I emailed you a few days back - perhaps you didnt see it? I have instead raised an issue just in case.
I have used your mcprotocol code in my node-red node node-red-contrib-mcprotocol for quite some time. I have only recently published this node but I would like to say, it has been running successfully, talking to a range of Mitsi PLCs for about 1 year.
Initially, I embedded your code (complete with original licence and full credit in the readme) and over this last year I have made extensive changes to your original code.
Most of this development was all before I fully understood the whole github arena & thus it is has many many changes I couldn't possibly hope to offer as individual PRs.
In an effort to rectify this, I have created a fork of https://github.com/plcpeople/mcprotocol here --> https://github.com/Steve-Mcl/mcprotocol and added all my private changes with the major changes under the commit message...
- mass update including UDP support, 3E, 4E and more ...
- Add UDP support (million times more stable than mitsi TCP)
- Add read() + write() functions for simple operations
- Support A, QnA, Q and L series
- add routing capability
- add enumerations for device codes, ranges, limits etc
- add debug levels
It is ultimately my intention to split the embedded mcprotocol code out of the node-red node & point it back to a separate mcprotocol library (be that my fork or your original works).
I wonder - rather than having 2 separate implementations, if it would be beneficial if this were a collaboration?
Are you intending on progressing the development of your implementation or should I simply continue to maintain my own fork? Please note, you are obviously welcome to take anything I have implemented back over to this original.
Let me know your thoughts, Steve.