From e867d871a56eba3832316609af5d9687b5c84174 Mon Sep 17 00:00:00 2001 From: kapilp93 Date: Thu, 1 Aug 2024 13:20:39 +0530 Subject: [PATCH 1/2] Added TooManyRequestsException to handle 429 response status code --- .../com/plivo/api/exceptions/TooManyRequestsException.java | 7 +++++++ src/main/java/com/plivo/api/models/base/BaseRequest.java | 3 +++ 2 files changed, 10 insertions(+) create mode 100644 src/main/java/com/plivo/api/exceptions/TooManyRequestsException.java diff --git a/src/main/java/com/plivo/api/exceptions/TooManyRequestsException.java b/src/main/java/com/plivo/api/exceptions/TooManyRequestsException.java new file mode 100644 index 000000000..e4e9b4fe9 --- /dev/null +++ b/src/main/java/com/plivo/api/exceptions/TooManyRequestsException.java @@ -0,0 +1,7 @@ +package com.plivo.api.exceptions; + +public class TooManyRequestsException extends PlivoRestException { + public TooManyRequestsException(String message) { + super(message); + } +} diff --git a/src/main/java/com/plivo/api/models/base/BaseRequest.java b/src/main/java/com/plivo/api/models/base/BaseRequest.java index c6c2b4ef3..92e99b371 100644 --- a/src/main/java/com/plivo/api/models/base/BaseRequest.java +++ b/src/main/java/com/plivo/api/models/base/BaseRequest.java @@ -11,6 +11,7 @@ import com.plivo.api.exceptions.PlivoRestException; import com.plivo.api.exceptions.ResourceNotFoundException; import com.plivo.api.exceptions.ServerException; +import com.plivo.api.exceptions.TooManyRequestsException; import java.io.IOException; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; @@ -88,6 +89,8 @@ protected void handleResponse(Response response) throws PlivoRestException, IOEx throw new ResourceNotFoundException(response.errorBody().string()); case 405: throw new InvalidRequestException(response.errorBody().string()); + case 429: + throw new TooManyRequestsException(response.errorBody().string()); case 500: throw new ServerException(response.errorBody().string()); } From f5f2b25e7ec16e61266401282c838f1e306ef8d3 Mon Sep 17 00:00:00 2001 From: kapilp93 Date: Wed, 14 Aug 2024 16:59:58 +0530 Subject: [PATCH 2/2] byoc-numbers field fix --- .../java/com/plivo/api/models/number/NumberCreator.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/plivo/api/models/number/NumberCreator.java b/src/main/java/com/plivo/api/models/number/NumberCreator.java index 2786fd654..8b825d8be 100644 --- a/src/main/java/com/plivo/api/models/number/NumberCreator.java +++ b/src/main/java/com/plivo/api/models/number/NumberCreator.java @@ -10,7 +10,7 @@ public class NumberCreator extends Creator { - private List numbers = new ArrayList<>(); + private String numbers; private String carrier; private String region; private NumberType numberType; @@ -22,12 +22,12 @@ public class NumberCreator extends Creator { throw new IllegalStateException("carrier, numbers and region are required"); } - this.numbers = numbers; + this.numbers = String.join(",", numbers); this.carrier = carrier; this.region = region; } - public List numbers() { + public String numbers() { return this.numbers; }