From aaf7192e013ee91675695eb894b8e795210b198f Mon Sep 17 00:00:00 2001 From: Koushik Shetty Date: Sun, 4 Mar 2018 21:14:28 +0530 Subject: [PATCH 1/2] add log incoming message field to the application --- .../com/plivo/api/models/application/Application.java | 8 ++++++++ .../api/models/application/ApplicationCreator.java | 10 ++++++++++ .../api/models/application/ApplicationUpdater.java | 11 +++++++++++ 3 files changed, 29 insertions(+) diff --git a/src/main/java/com/plivo/api/models/application/Application.java b/src/main/java/com/plivo/api/models/application/Application.java index 7fb80bee..d588e8ac 100644 --- a/src/main/java/com/plivo/api/models/application/Application.java +++ b/src/main/java/com/plivo/api/models/application/Application.java @@ -23,6 +23,7 @@ public class Application extends BaseResource { private String resourceUri; private String sipUri; private String subAccount; + private Boolean logIncomingMessage; public static ApplicationCreator creator(String appName) { return new ApplicationCreator(appName); @@ -168,6 +169,13 @@ public String getSubAccount() { return subAccount; } + /** + * @return indicates if the the incoming message will be logged. By default it is true + */ + public Boolean getLogIncomingMessage() { + return logIncomingMessage; + } + public ApplicationUpdater updater() { return Application.updater(appId); } diff --git a/src/main/java/com/plivo/api/models/application/ApplicationCreator.java b/src/main/java/com/plivo/api/models/application/ApplicationCreator.java index 82a96914..74bb9222 100644 --- a/src/main/java/com/plivo/api/models/application/ApplicationCreator.java +++ b/src/main/java/com/plivo/api/models/application/ApplicationCreator.java @@ -18,6 +18,7 @@ public class ApplicationCreator extends Creator { private Boolean defaultNumberApp; private Boolean defaultEndpointApp; private String subaccount; + private Boolean logIncomingMessage; /** * @param appName The name of your application @@ -78,6 +79,10 @@ public String subaccount() { return this.subaccount; } + public Boolean logIncomingMessage() { + return this.logIncomingMessage; + } + public ApplicationCreator appName(final String appName) { this.appName = appName; return this; @@ -138,6 +143,11 @@ public ApplicationCreator subaccount(final String subaccount) { return this; } + public ApplicationCreator logIncomingMessage(final Boolean logIncomingMessage) { + this.logIncomingMessage = logIncomingMessage; + return this; + } + @Override protected Call obtainCall() { return client().getApiService().applicationCreate(client().getAuthId(), this); diff --git a/src/main/java/com/plivo/api/models/application/ApplicationUpdater.java b/src/main/java/com/plivo/api/models/application/ApplicationUpdater.java index 9418d54d..77cc966f 100644 --- a/src/main/java/com/plivo/api/models/application/ApplicationUpdater.java +++ b/src/main/java/com/plivo/api/models/application/ApplicationUpdater.java @@ -16,6 +16,7 @@ public class ApplicationUpdater extends Updater { private Boolean defaultNumberApp; private Boolean defaultEndpointApp; private String subaccount; + private Boolean logIncomingMessage; public ApplicationUpdater(String id) { super(id); @@ -64,6 +65,10 @@ public Boolean defaultEndpointApp() { public String subaccount() { return this.subaccount; } + + public Boolean logIncomingMessage() { + return this.logIncomingMessage; + } public ApplicationUpdater answerUrl(final String answerUrl) { this.answerUrl = answerUrl; @@ -120,6 +125,12 @@ public ApplicationUpdater subaccount(final String subaccount) { return this; } + public ApplicationUpdater logIncomingMessage(final Boolean logIncomingMessage) { + this.logIncomingMessage = logIncomingMessage; + return this; + } + + @Override protected Call obtainCall() { From 1ec7166ee276e54ea53b587480a8acf15fb4b678 Mon Sep 17 00:00:00 2001 From: Koushik Shetty Date: Sun, 4 Mar 2018 22:24:52 +0530 Subject: [PATCH 2/2] update tests --- .../java/com/plivo/api/ApplicationTest.java | 1 + .../com/plivo/api/applicationGetResponse.json | 3 ++- .../plivo/api/applicationListResponse.json | 24 ++++++++++++------- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/src/test/java/com/plivo/api/ApplicationTest.java b/src/test/java/com/plivo/api/ApplicationTest.java index bad6fbae..d46e2467 100644 --- a/src/test/java/com/plivo/api/ApplicationTest.java +++ b/src/test/java/com/plivo/api/ApplicationTest.java @@ -23,6 +23,7 @@ public void applicationCreateShouldSucceed() throws Exception { .fallbackMethod("POST") .messageUrl("http://message.url") .messageMethod("POST") + .logIncomingMessage(true) .create(); assertRequest("POST", "Application/"); diff --git a/src/test/resources/com/plivo/api/applicationGetResponse.json b/src/test/resources/com/plivo/api/applicationGetResponse.json index 98b051b0..a7727aae 100644 --- a/src/test/resources/com/plivo/api/applicationGetResponse.json +++ b/src/test/resources/com/plivo/api/applicationGetResponse.json @@ -16,5 +16,6 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/20468599130939380/", "sip_uri": "sip:20468599130939380@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true } \ No newline at end of file diff --git a/src/test/resources/com/plivo/api/applicationListResponse.json b/src/test/resources/com/plivo/api/applicationListResponse.json index 93c2cc15..27e24266 100644 --- a/src/test/resources/com/plivo/api/applicationListResponse.json +++ b/src/test/resources/com/plivo/api/applicationListResponse.json @@ -25,7 +25,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/20468599130939380/", "sip_uri": "sip:20468599130939380@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true }, { "answer_method": "POST", @@ -44,7 +45,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/13094892674577059/", "sip_uri": "sip:13094892674577059@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": false }, { "answer_method": "POST", @@ -63,7 +65,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/64529074997228907/", "sip_uri": "sip:64529074997228907@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true }, { "answer_method": "GET", @@ -82,7 +85,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/30042999414609341/", "sip_uri": "sip:30042999414609341@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true }, { "answer_method": "GET", @@ -101,7 +105,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/30042349822904887/", "sip_uri": "sip:30042349822904887@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true }, { "answer_method": "GET", @@ -120,7 +125,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/30041373335801898/", "sip_uri": "sip:30041373335801898@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true }, { "answer_method": "POST", @@ -139,7 +145,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/30040535577211472/", "sip_uri": "sip:30040535577211472@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true }, { "answer_method": "GET", @@ -158,7 +165,8 @@ "public_uri": false, "resource_uri": "/v1/Account/MAXXXXXXXXXXXXXXXXXX/Application/30039778631346811/", "sip_uri": "sip:30039778631346811@app.plivo.com", - "sub_account": null + "sub_account": null, + "log_incoming_message": true } ] } \ No newline at end of file