From 9624e0f56cb819bd27132061250659172ffd8373 Mon Sep 17 00:00:00 2001 From: narayana-plivo Date: Tue, 18 Feb 2025 15:50:00 +0530 Subject: [PATCH 1/3] handle specific error --- .../Message/MessageCreateErrorResponse.php | 38 +++++++++++++++++++ .../Resources/Message/MessageInterface.php | 7 ++++ 2 files changed, 45 insertions(+) create mode 100644 src/Plivo/Resources/Message/MessageCreateErrorResponse.php diff --git a/src/Plivo/Resources/Message/MessageCreateErrorResponse.php b/src/Plivo/Resources/Message/MessageCreateErrorResponse.php new file mode 100644 index 00000000..e5ff3483 --- /dev/null +++ b/src/Plivo/Resources/Message/MessageCreateErrorResponse.php @@ -0,0 +1,38 @@ +apiID = $apiID; + $this->error = $error; + } + + /** + * Get the message ID + * @return array + */ + public function getApiId() + { + return $this->apiId; + } + + +} \ No newline at end of file diff --git a/src/Plivo/Resources/Message/MessageInterface.php b/src/Plivo/Resources/Message/MessageInterface.php index 3e783ee8..3b8d8a67 100644 --- a/src/Plivo/Resources/Message/MessageInterface.php +++ b/src/Plivo/Resources/Message/MessageInterface.php @@ -258,6 +258,13 @@ public function create($src=null, $dst=null, $text=null,array $optionalArgs = [] ); } } else { + if ($response->getStatusCode() > 399 && $response->getStatusCode() < 499) { + return new MessageCreateErrorResponse( + $responseContents['error'], + $responseContents['api_id'], + $response->getStatusCode() + ); + } throw new PlivoResponseException( $responseContents['error'], 0, From 2e009cd1df30c642ff60f34a605fd91f577914a1 Mon Sep 17 00:00:00 2001 From: narayana-plivo Date: Tue, 18 Feb 2025 16:07:07 +0530 Subject: [PATCH 2/3] make it public --- src/Plivo/Resources/Message/MessageCreateErrorResponse.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Plivo/Resources/Message/MessageCreateErrorResponse.php b/src/Plivo/Resources/Message/MessageCreateErrorResponse.php index e5ff3483..c4b593cd 100644 --- a/src/Plivo/Resources/Message/MessageCreateErrorResponse.php +++ b/src/Plivo/Resources/Message/MessageCreateErrorResponse.php @@ -11,8 +11,8 @@ */ class MessageCreateErrorResponse extends ResponseUpdate { - protected $apiId = ""; - protected $error = ""; + public $apiId = ""; + public $error = ""; /** * MessageCreateErrorResponse constructor. * @param $error @@ -21,8 +21,8 @@ class MessageCreateErrorResponse extends ResponseUpdate public function __construct($error, $apiId,$statusCode) { parent::__construct($apiId, $error, $statusCode); - $this->apiID = $apiID; $this->error = $error; + $this->apiId = $apiId; } /** From e47b49b37991282d40848e053c2bb25b62a22121 Mon Sep 17 00:00:00 2001 From: narayana-plivo Date: Tue, 18 Feb 2025 17:24:54 +0530 Subject: [PATCH 3/3] fix --- CHANGELOG.md | 4 ++++ src/Plivo/Version.php | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 86d6b69c..ae41872a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,8 @@ # Change Log +## [4.66.4](https://github.com/plivo/plivo-php/tree/v4.66.4) (2025-02-18) +**Enhancement** +-Handle the error response from the send sms api + ## [4.66.3](https://github.com/plivo/plivo-php/tree/v4.66.3) (2024-11-08) **Bug fix** -Fix subsquent requests to other services after a lookup request diff --git a/src/Plivo/Version.php b/src/Plivo/Version.php index cb751ddd..b3b78598 100644 --- a/src/Plivo/Version.php +++ b/src/Plivo/Version.php @@ -26,7 +26,7 @@ class Version * @const int PHP helper library patch number */ - const PATCH = 3; + const PATCH = 4; /** * @return string