From 2e79587fe43d12b06b214b754343ca187894009c Mon Sep 17 00:00:00 2001 From: prabhav-plivo Date: Wed, 26 Jul 2023 12:44:26 +0530 Subject: [PATCH 1/2] added cnam-storage changes --- plivo/resources/numbers.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/plivo/resources/numbers.py b/plivo/resources/numbers.py index c676dbef..943619a5 100644 --- a/plivo/resources/numbers.py +++ b/plivo/resources/numbers.py @@ -34,8 +34,11 @@ def __init__(self, client): number=[is_phonenumber()], app_id=[optional(of_type(six.text_type))], verification_info=[optional(of_type_exact(dict))], - cnam_lookup=[optional(of_type(six.text_type))],) - def buy(self, number, app_id=None, verification_info=None, cnam_lookup=None): + cnam_lookup=[optional(of_type(six.text_type))], + cnam=[optional(of_type(six.text_type))], + callback_url=[optional(of_type(six.text_type))], + callback_method=[optional(of_type(six.text_type))],) + def buy(self, number, app_id=None, verification_info=None, cnam_lookup=None, cnam=None, callback_url=None, callback_method=None): return self.client.request('POST', ('PhoneNumber', number), to_param_dict(self.buy, locals())) @@ -90,6 +93,7 @@ def list(self, renewal_date__gte=None, renewal_date__gt=None, cnam_lookup=None, + cnam=None, limit=20, offset=0): return self.client.request( @@ -131,7 +135,10 @@ def update(self, subaccount=None, alias=None, verification_info=None, - cnam_lookup=None,): + cnam_lookup=None, + cnam=None, + callback_url=None, + callback_method=None,): return self.client.request('POST', ('Number', number), to_param_dict(self.update, locals())) From d5cc397980a229a1dca8e976824e2692120ebb89 Mon Sep 17 00:00:00 2001 From: prabhav-plivo Date: Fri, 28 Jul 2023 12:47:29 +0530 Subject: [PATCH 2/2] added cnam field in tests --- tests/resources/fixtures/numberGetResponse.json | 1 + tests/resources/fixtures/numberListResponse.json | 3 +++ 2 files changed, 4 insertions(+) diff --git a/tests/resources/fixtures/numberGetResponse.json b/tests/resources/fixtures/numberGetResponse.json index b625ffa7..82873531 100644 --- a/tests/resources/fixtures/numberGetResponse.json +++ b/tests/resources/fixtures/numberGetResponse.json @@ -9,6 +9,7 @@ "number": "17609915566", "number_type": "local", "city": "USA", + "cnam": "plivo", "cnam_lookup": "enabled", "compliance_application_id": null, "compliance_status": null, diff --git a/tests/resources/fixtures/numberListResponse.json b/tests/resources/fixtures/numberListResponse.json index c341595b..4d4a9ad6 100644 --- a/tests/resources/fixtures/numberListResponse.json +++ b/tests/resources/fixtures/numberListResponse.json @@ -32,6 +32,7 @@ "tendlc_registration_status": "PROCESSING", "toll_free_sms_verification": null, "renewal_date": "2014-09-05", + "cnam": "plivo", "cnam_lookup": "enabled", "voice_enabled": true, "voice_rate": "0.00850" @@ -60,6 +61,7 @@ "tendlc_registration_status": "REGISTERED", "toll_free_sms_verification": null, "renewal_date": "2013-02-01", + "cnam": "", "cnam_lookup": "enabled", "voice_enabled": true, "voice_rate": "0.00850" @@ -87,6 +89,7 @@ "tendlc_registration_status": null, "toll_free_sms_verification": "verified", "renewal_date": "2013-04-25", + "cnam": "plivo", "cnam_lookup": "disabled", "voice_enabled": true, "voice_rate": "0.00850"