Skip to content

Commit 0c673a4

Browse files
Merge pull request #754 from plotly/renamefn
rename badly-named function
2 parents cf5c342 + ad2eeba commit 0c673a4

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/PlotlyEditor.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ class PlotlyEditor extends Component {
99
super();
1010
this.state = {graphDiv: {}};
1111
this.PlotComponent = createPlotComponent(props.plotly);
12-
this.handleDirectUpdate = this.handleDirectUpdate.bind(this);
12+
this.handleRender = this.handleRender.bind(this);
1313
}
1414

15-
handleDirectUpdate(fig, graphDiv) {
15+
handleRender(fig, graphDiv) {
1616
this.setState({graphDiv});
17-
if (this.props.onDirectUpdate) {
18-
this.props.onDirectUpdate(graphDiv.data, graphDiv.layout, graphDiv._transitionData._frames);
17+
if (this.props.onRender) {
18+
this.props.onRender(graphDiv.data, graphDiv.layout, graphDiv._transitionData._frames);
1919
}
2020
}
2121

@@ -52,8 +52,8 @@ class PlotlyEditor extends Component {
5252
config={this.props.config}
5353
useResizeHandler={this.props.useResizeHandler}
5454
debug={this.props.debug}
55-
onInitialized={this.handleDirectUpdate}
56-
onUpdate={this.handleDirectUpdate}
55+
onInitialized={this.handleRender}
56+
onUpdate={this.handleRender}
5757
style={{width: '100%', height: '100%'}}
5858
divId={this.props.divId}
5959
/>
@@ -72,7 +72,7 @@ PlotlyEditor.propTypes = {
7272
dataSources: PropTypes.object,
7373
frames: PropTypes.array,
7474
onUpdate: PropTypes.func,
75-
onDirectUpdate: PropTypes.func,
75+
onRender: PropTypes.func,
7676
plotly: PropTypes.object,
7777
useResizeHandler: PropTypes.bool,
7878
debug: PropTypes.bool,

0 commit comments

Comments
 (0)