Skip to content

Commit d1abfe0

Browse files
authored
Merge pull request #501 from plotly/table-column-defaults
Infer headers on tables
2 parents c9c457f + 77f7912 commit d1abfe0

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

src/EditorControls.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
shamefullyClearAxisTypes,
77
shamefullyAdjustAxisRef,
88
shamefullyAdjustGeo,
9+
shamefullyAddTableColumns,
910
} from './shame';
1011
import {EDITOR_ACTIONS} from './lib/constants';
1112
import isNumeric from 'fast-isnumeric';
@@ -62,6 +63,7 @@ class EditorControls extends Component {
6263

6364
shamefullyClearAxisTypes(graphDiv, payload);
6465
shamefullyAdjustAxisRef(graphDiv, payload);
66+
shamefullyAddTableColumns(graphDiv, payload);
6567

6668
for (let i = 0; i < payload.traceIndexes.length; i++) {
6769
for (const attr in payload.update) {

src/shame.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,3 +82,21 @@ export const shamefullyAdjustGeo = ({layout: {geo = {}}}, {update}) => {
8282
update['geo.center'] = {};
8383
}
8484
};
85+
86+
export const shamefullyAddTableColumns = (graphDiv, {traceIndexes, update}) => {
87+
if (
88+
update['cells.values'] &&
89+
(!graphDiv.data[traceIndexes[0]].header ||
90+
!graphDiv.data[traceIndexes[0]].header.valuessrc)
91+
) {
92+
update['header.values'] = update['cells.valuessrc'];
93+
} else if (update['header.values'] === null) {
94+
update['header.values'] =
95+
graphDiv.data[traceIndexes[0]].cells.valuessrc || null;
96+
} else if (
97+
update['cells.values'] === null &&
98+
!graphDiv.data[traceIndexes[0]].header.valuessrc
99+
) {
100+
update['header.values'] = null;
101+
}
102+
};

0 commit comments

Comments
 (0)