Skip to content

Batch updates with rafz #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mike-Dax wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Batch updates with rafz #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@
"webpack": "^4.43.0"
},
"dependencies": {
"debounce": "^1.2.0"
"debounce": "^1.2.0",
"rafz": "^0.1.14"
}
}
12 changes: 11 additions & 1 deletion src/web/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useEffect, useState, useRef, useMemo } from 'react'
import { debounce as createDebounce } from 'debounce'
import { raf } from 'rafz'

declare type ResizeObserverCallback = (entries: any[], observer: ResizeObserver) => void
declare class ResizeObserver {
Expand Down Expand Up @@ -76,6 +77,10 @@ function useMeasure({ debounce, scroll, polyfill }: Options = { debounce: 0, scr

// memoize handlers, so event-listeners know when they should update
const [forceRefresh, resizeChange, scrollChange] = useMemo(() => {
const setState = () => {
set(state.current.lastBounds)
}

const callback = () => {
if (!state.current.element) return
const {
Expand All @@ -90,8 +95,13 @@ function useMeasure({ debounce, scroll, polyfill }: Options = { debounce: 0, scr
} = (state.current.element.getBoundingClientRect() as unknown) as RectReadOnly
const size = { left, top, width, height, bottom, right, x, y }
Object.freeze(size)
if (mounted.current && !areBoundsEqual(state.current.lastBounds, size)) set((state.current.lastBounds = size))

if (mounted.current && !areBoundsEqual(state.current.lastBounds, size)) {
state.current.lastBounds = size
raf.write(setState)
}
}

return [
callback,
resizeDebounce ? createDebounce(callback, resizeDebounce) : callback,
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5502,6 +5502,11 @@ querystring@0.2.0:
resolved "https://registry.yarnpkg.com/querystring/-/querystring-0.2.0.tgz#b209849203bb25df820da756e747005878521620"
integrity sha1-sgmEkgO7Jd+CDadW50cAWHhSFiA=

rafz@^0.1.14:
version "0.1.14"
resolved "https://registry.yarnpkg.com/rafz/-/rafz-0.1.14.tgz#164f01cf7cc6094e08467247ef351ef5c8d278fe"
integrity sha512-YiQkedSt1urYtYbvHhTQR3l67M8SZbUvga5eJFM/v4vx/GmDdtXlE2hjJIyRjhhO/PjcdGC+CXCYOUA4onit8w==

randombytes@^2.0.0, randombytes@^2.0.1, randombytes@^2.0.5, randombytes@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/randombytes/-/randombytes-2.1.0.tgz#df6f84372f0270dc65cdf6291349ab7a473d4f2a"
Expand Down