Add hack

Author: kubukoz

sbtPlugin/src/main/scala/org/polyvariant/smithytraitcodegen/SmithyTraitCodegen.scala

@@ -25,6 +25,9 @@ import software.amazon.smithy.model.node.ObjectNode
 import software.amazon.smithy.traitcodegen.TraitCodegenPlugin
 
 import java.io.File
+import software.amazon.smithy.model.transform.ModelTransformer
+import java.util.stream.Collectors
+import scala.collection.JavaConverters.*
 
 object SmithyTraitCodegen {
 
@@ -108,6 +111,23 @@ object SmithyTraitCodegen {
 
   }
 
+  // Hack / workaround for https://github.com/smithy-lang/smithy/pull/2671
+  private def namespaceHackRequired(ns: String) =
+    ns.startsWith("smithy") && ns != "smithy" && !ns.startsWith("smithy.")
+
+  private def renameNamespaceForHack(ns: String) =
+    if (namespaceHackRequired(ns))
+      "hack" + ns
+    else
+      ns
+
+  private def replaceNamespaceRefsInFile(fileText: String, ns: String) =
+    if (namespaceHackRequired(ns)) {
+      fileText.replaceAll(s"hack$ns", ns)
+    } else {
+      fileText
+    }
+
   def generate(args: Args): Output = {
     val outputDir = args.targetDir / "smithy-trait-generator-output"
     val genDir = outputDir / "java"
@@ -117,13 +137,38 @@ object SmithyTraitCodegen {
 
     val manifest = FileManifest.create(genDir.toNIO)
 
-    val model = args
-      .dependencies
-      .foldLeft(Model.assembler().addImport(args.smithySourcesDir.path.toNIO)) { case (acc, dep) =>
-        acc.addImport(dep.path.toNIO)
+    val model =
+      args
+        .dependencies
+        .foldLeft(Model.assembler().addImport(args.smithySourcesDir.path.toNIO)) {
+          case (acc, dep) => acc.addImport(dep.path.toNIO)
+        }
+        .assemble()
+        .unwrap() match {
+        case model =>
+          if (namespaceHackRequired(args.smithyNamespace)) {
+            println("Applying namespace workaround - `hack` prefix will be used")
+
+            val renames =
+              model
+                .shapes()
+                .collect(Collectors.toList())
+                .asScala
+                .filter(_.getId().getNamespace() == args.smithyNamespace)
+                .map { shp =>
+                  shp.getId() ->
+                    shp.getId().withNamespace(renameNamespaceForHack(shp.getId().getNamespace()))
+                }
+                .toMap
+                .asJava
+
+            ModelTransformer
+              .create()
+              .renameShapes(model, renames)
+          } else
+            model
       }
-      .assemble()
-      .unwrap()
+
     val context = PluginContext
       .builder()
       .model(model)
@@ -132,7 +177,7 @@ object SmithyTraitCodegen {
         ObjectNode
           .builder()
           .withMember("package", args.javaPackage)
-          .withMember("namespace", args.smithyNamespace)
+          .withMember("namespace", renameNamespaceForHack(args.smithyNamespace))
           .withMember("header", ArrayNode.builder.build())
           .withMember("excludeTags", ArrayNode.builder.withValue("nocodegen").build())
           .build()
@@ -145,6 +190,13 @@ object SmithyTraitCodegen {
     if (os.exists(genDir / "META-INF"))
       os.move(genDir / "META-INF", metaDir / "META-INF")
 
+    os.walk(genDir)
+      .filter(os.isFile)
+      .filter(_.ext == "java")
+      .foreach { f =>
+        os.write.over(f, replaceNamespaceRefsInFile(os.read(f), args.smithyNamespace))
+      }
+
     os
       .walk(metaDir, includeTarget = true)
       .filter(os.isFile)

sbtPlugin/src/sbt-test/codegen/namespace-restriction-hack/build.sbt

@@ -0,0 +1,13 @@
+val traits = project
+  .enablePlugins(SmithyTraitCodegenPlugin)
+  .settings(
+    smithyTraitCodegenDependencies := List(
+      "io.github.disneystreaming.alloy" % "alloy-core" % "0.3.23"
+    ),
+    smithyTraitCodegenJavaPackage := "smithy4bazinga",
+    smithyTraitCodegenNamespace := "smithy4bazinga",
+  )
+
+val root = project
+  .in(file("."))
+  .dependsOn(traits)

sbtPlugin/src/sbt-test/codegen/namespace-restriction-hack/project/plugins.sbt

@@ -0,0 +1,5 @@
+sys.props.get("plugin.version") match {
+  case Some(x) => addSbtPlugin("org.polyvariant" % "smithy-trait-codegen-sbt" % x)
+  case _       => sys.error("""|The system property 'plugin.version' is not defined.
+                         |Specify this property using the scriptedLaunchOpts -D.""".stripMargin)
+}

sbtPlugin/src/sbt-test/codegen/namespace-restriction-hack/src/main/scala/Demo.scala

@@ -0,0 +1,8 @@
+import software.amazon.smithy.model.Model
+
+object DemoApp extends App {
+  assert(
+    smithy4bazinga.BazingaTrait.ID.toString() == "smithy4bazinga#bazinga",
+    s"Expected smithy4bazinga.BazingaTrait.ID to be 'smithy4bazinga#bazinga', but got ${smithy4bazinga.BazingaTrait.ID.toString()}",
+  )
+}

sbtPlugin/src/sbt-test/codegen/namespace-restriction-hack/test

@@ -0,0 +1 @@
+> run

sbtPlugin/src/sbt-test/codegen/namespace-restriction-hack/traits/src/main/resources/META-INF/smithy/manifest

@@ -0,0 +1 @@
+smithy4bazinga.smithy

sbtPlugin/src/sbt-test/codegen/namespace-restriction-hack/traits/src/main/resources/META-INF/smithy/smithy4bazinga.smithy

@@ -0,0 +1,6 @@
+$version: "2"
+
+namespace smithy4bazinga
+
+@trait
+string bazinga