Serious bug with the input validate method

I was working with some form validation on a public facing site and noticed that the current validationEngine code does not properly validate single input fields in a form. The bug was discovered as an issue of "re-scoping".

Within the else block of the methods._validate() function, the valid variable was being rescoped and edited within. However, the variable assignment would not transcend up to the global function variables (see Line 106). As such, I removed the "re-scoping" and added a return !valid because the value of valid after Lines 140-144 is inverted. We need to properly return True for Valid and False for Invalid.

Author: stephnr

js/jquery.validationEngine.js

@@ -133,9 +133,17 @@
 				element.removeClass('validating');
 			} else {
 				// field validation
-				var form = element.closest('form, .validationEngineContainer'),
-					options = (form.data('jqv')) ? form.data('jqv') : $.validationEngine.defaults,
-					valid = methods._validateField(element, options);
+		                var form = element.closest('form, .validationEngineContainer');
+		                options = (form.data('jqv')) ? form.data('jqv') : $.validationEngine.defaults;
+		                valid = methods._validateField(element, options);
+		
+		                if (valid && options.onFieldSuccess)
+		                    options.onFieldSuccess();
+		                else if (options.onFieldFailure && options.InvalidFields.length > 0) {
+		                    options.onFieldFailure();
+		                }
+		
+		                return !valid;
 			}
 			if(options.onValidationComplete) {
 				// !! ensures that an undefined return is interpreted as return false but allows a onValidationComplete() to possibly return true and have form continue processing