Add support for server reflection using v1 protocol #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvgupta03
changed the title
There was a problem hiding this comment.
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
test-reflection.js:7
- [nitpick] Consider renaming 'testReflection' to something like 'runReflectionTest' to better reflect its side-effect behavior.
async function testReflection() {
c81ac46 to
793b178
Compare
apoorvgupta03
force-pushed
the
feat/supportV1Reflection
branch
3 times, most recently
from
378092a to
334e793
Compare
apoorvgupta03
force-pushed
the
feat/supportV1Reflection
branch
from
334e793 to
ccd4e9f
Compare
Collaborator
|
Closing this as the implementation has been added via #5. Thanks a ton @apoorvgupta03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc-reflect-example-auto.zip