Skip to content

Commit 1083a50

Browse files
remove submodule
1 parent 3aa8fff commit 1083a50

File tree

3 files changed

+19
-7
lines changed

3 files changed

+19
-7
lines changed

.github/workflows/dev-packages.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Action to publish packages under the `next` tag for testing
2-
# Packages are versioned as `0.0.0-dev.{short-sha}`
2+
# Packages are versioned as `0.0.0-{tag}-DATETIMESTAMP`
33
name: Packages Deploy
44

55
on: workflow_dispatch

.gitmodules

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
[submodule "apps/supabase-todolist"]
22
path = apps/supabase-todolist
33
url = git@github.com:journeyapps/powersync-supabase-react-native-todolist-demo.git
4-
[submodule "packages/journeyapps-react-native-quick-sqlite"]
5-
path = packages/journeyapps-react-native-quick-sqlite
6-
url = git@github.com:journeyapps/react-native-quick-sqlite.git

README.md

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ yarn build:packages
4242

4343

4444
### Development Packages
45-
Development packages can be published by manually triggering the `dev-packages` workflow. Development packages are versioned as `0.0.0-dev.{short-sha}`.
45+
Development packages can be published by manually triggering the `dev-packages` workflow. Development packages are versioned as `0.0.0-{tag}-DATETIMESTAMP`.
4646

4747
### Production Packages
4848
Pull requests should contain Changesets for changed packages.
@@ -52,10 +52,25 @@ Add changesets with
5252
yarn changeset add
5353
```
5454

55-
Submodule production packages should be versioned, tagged and published from their own repository. Any dependencies should be updated here (if applicable) before merging pull requests.
55+
Merging a PR with Changesets will automatically create a PR with version bumps. That PR will be merged when releasing.
5656

57+
## React Native Quick SQLite Development
58+
59+
Testing live development changes to `@journeyapps/react-native-quick-sqlite` will not with with standard `yarn link` commands. Metro does not work well with symlinks https://github.com/facebook/metro/issues/286.
60+
61+
The process of releasing development packages for `@journeyapps/react-native-quick-sqlite` for each change can be tedious and slow. A faster (and hackier) method is to use [mtsl](https://www.npmjs.com/package/mtsl) which will watch and copy the package into this workspace's `node_modules`.
62+
63+
```bash
64+
npm install -g mtsl
65+
```
66+
```bash
67+
mtsl add -s "[ource path to your react-native-quick-sqlite repo folder]" -d "[this workspaces root node_modules folder]"/@journeyapps/react-native-quick-sqlite
68+
```
69+
70+
```bash
71+
mtsl start "[the id returned from step above]"
72+
```
5773

58-
Merging a PR with Changesets will automatically create a PR with version bumps. That PR will be merged when releasing.
5974

6075
## Testing Supabase example app
6176

0 commit comments

Comments
 (0)