Skip to content

Commit 4d46bd0

Browse files
Apply suggestions from code review
Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com>
1 parent 2c1a0ab commit 4d46bd0

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

packages/powersync-sdk-common/src/client/AbstractPowerSyncDatabase.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export abstract class AbstractPowerSyncDatabase extends BaseObserver<PowerSyncDB
126126
/**
127127
* The underlying database.
128128
*
129-
* For the most part, behavior is the same whether querying on the underlying database, or on {@link AbstractPowerSyncDatabase}. The main difference is in update notifications: the underlying database reports updates to the underlying tables, while AbstractPowerSyncDatabase reports updates to the higher-level views.
129+
* For the most part, behavior is the same whether querying on the underlying database, or on {@link AbstractPowerSyncDatabase}.
130130
*/
131131
protected get database() {
132132
return this.options.database;

packages/powersync-sdk-common/src/client/sync/bucket/CrudBatch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { CrudEntry } from './CrudEntry';
22

33
/**
4-
* TODO
4+
* A batch of client-side changes.
55
*/
66
export class CrudBatch {
77
constructor(

packages/powersync-sdk-common/src/client/sync/bucket/CrudTransaction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export class CrudTransaction extends CrudBatch {
1515
*/
1616
public complete: (checkpoint?: string) => Promise<void>,
1717
/**
18-
* Unique transaction id.
18+
* If null, this contains a list of changes recorded without an explicit transaction associated.
1919
*/
2020
public transactionId?: number
2121
) {

packages/powersync-sdk-common/src/db/crud/SyncStatus.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ export class SyncStatus {
2222
}
2323

2424
/**
25-
* TODO
25+
* Time that a last sync has fully completed, if any.
26+
* Currently this is reset to null after a restart.
2627
*/
2728
get lastSyncedAt() {
2829
return this.options.lastSyncedAt;

0 commit comments

Comments
 (0)