WIP: Consistent getOptional error message

mugikhan · mugikhan · commit 785e960d057e · 2024-10-09T16:06:50.000+02:00
diff --git a/packages/powersync-op-sqlite/src/db/OPSQLiteConnection.ts b/packages/powersync-op-sqlite/src/db/OPSQLiteConnection.ts
@@ -75,8 +75,7 @@ export class OPSQLiteConnection extends BaseObserver<DBAdapterListener> {
   async get<T>(sql: string, parameters?: any[]): Promise<T> {
     const result = await this.getOptional(sql, parameters);
     if (!result) {
-      // TODO more consistent error
-      throw new Error(`No row returned for [get] query`);
+      throw new Error('Result set is empty');
     }
     return result as T;
   }

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,7 @@ export class OPSQLiteConnection extends BaseObserver<DBAdapterListener> {`
`75`	`75`	`async get<T>(sql: string, parameters?: any[]): Promise<T> {`
`76`	`76`	`const result = await this.getOptional(sql, parameters);`
`77`	`77`	`if (!result) {`
`78`		`- // TODO more consistent error`
`79`		- throw new Error(`No row returned for [get] query`);
	`78`	`+ throw new Error('Result set is empty');`
`80`	`79`	`}`
`81`	`80`	`return result as T;`
`82`	`81`	`}`