chore(common): improve deleteBucket function (#268)

Co-authored-by: DominicGBauer <dominic@nomanini.com>

Author: DominicGBauer

.changeset/afraid-bulldogs-check.md

@@ -0,0 +1,5 @@
+---
+'@powersync/common': patch
+---
+
+Change internals of deleteBucket to use simpler action

packages/common/src/client/sync/bucket/SqliteBucketStorage.ts

@@ -103,26 +103,12 @@ export class SqliteBucketStorage extends BaseObserver<BucketStorageListener> imp
    * Mark a bucket for deletion.
    */
   private async deleteBucket(bucket: string) {
-    // Delete a bucket, but allow it to be re-created.
-    // To achieve this, we rename the bucket to a new temp name, and change all ops to remove.
-    // By itself, this new bucket would ensure that the previous objects are deleted if they contain no more references.
-    // If the old bucket is re-added, this new bucket would have no effect.
     await this.writeTransaction(async (tx) => {
-      const { uuid } = await tx.get<{ uuid: string }>('select uuid() as uuid');
-      const newName = `$delete_${bucket}_${uuid}`;
-      this.logger.debug('Deleting bucket', bucket);
       await tx.execute(
-        `UPDATE ps_oplog SET op=${OpTypeEnum.REMOVE}, data=NULL WHERE op=${OpTypeEnum.PUT} AND superseded=0 AND bucket=?`,
-        [bucket]
-      );
-      // Rename bucket
-      await tx.execute('UPDATE ps_oplog SET bucket=? WHERE bucket=?', [newName, bucket]);
-      await tx.execute('DELETE FROM ps_buckets WHERE name = ?', [bucket]);
-      await tx.execute(
-        'INSERT INTO ps_buckets(name, pending_delete, last_op) SELECT ?, 1, IFNULL(MAX(op_id), 0) FROM ps_oplog WHERE bucket = ?',
-        [newName, newName]
-      );
+          'INSERT INTO powersync_operations(op, data) VALUES(?, ?)',
+          ['delete_bucket', bucket]);
     });
+
     this.logger.debug('done deleting bucket');
     this.pendingBucketDeletes = true;
   }