Skip to content

Commit f9b9a96

Browse files
ChriztiaanChristiaan Landman
andauthored
fix default onError callback values for watch() and onChange() (#134)
Co-authored-by: Christiaan Landman <christiaanlandman@Christiaans-MacBook-Pro-2.local>
1 parent 36fed1a commit f9b9a96

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.changeset/rare-pumpkins-study.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@journeyapps/powersync-sdk-common": patch
3+
---
4+
5+
Fixed default onError callback for watch() and onChange() that used an unbounded member.

packages/powersync-sdk-common/src/client/AbstractPowerSyncDatabase.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ export abstract class AbstractPowerSyncDatabase extends BaseObserver<PowerSyncDB
695695
* Note that the `onChange` callback member of the handler is required.
696696
*/
697697
watchWithCallback(sql: string, parameters?: any[], handler?: WatchHandler, options?: SQLWatchOptions): void {
698-
const { onResult, onError = this.options.logger?.error } = handler ?? {};
698+
const { onResult, onError = (e: Error) => this.options.logger?.error(e) } = handler ?? {};
699699
if (!onResult) {
700700
throw new Error('onResult is required');
701701
}
@@ -829,7 +829,7 @@ export abstract class AbstractPowerSyncDatabase extends BaseObserver<PowerSyncDB
829829
* Returns dispose function to stop watching.
830830
*/
831831
onChangeWithCallback(handler?: WatchOnChangeHandler, options?: SQLWatchOptions): () => void {
832-
const { onChange, onError = this.options.logger?.error } = handler ?? {};
832+
const { onChange, onError = (e: Error) => this.options.logger?.error(e) } = handler ?? {};
833833
if (!onChange) {
834834
throw new Error('onChange is required');
835835
}

0 commit comments

Comments
 (0)