Skip to content

S3 object tagging #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

S3 object tagging #343

wants to merge 36 commits into from

Conversation

@byterock
Copy link
Collaborator

@byterock byterock commented Sep 5, 2019

ok here is the fixe for S3 Put Tagging and some tests for get and put

byterock and others added 5 commits June 24, 2019 11:50
@byterock
update changes file
c0fbbbb
@byterock
Test Suite for Pinpoint
8d8db43 
Here are  pattern tests for all the work I have done on pinpoint. I used
real world obstificed data where I had it and the filled in the blank
parts with dummy data.
@byterock
Merge branch 'master' into master
5aa27fd
fixes for s3 ObjectTagging get and push
685d405
S3 changes added in correct code and status and https status and test…
55f231c 
…s for changes
@byterock byterock mentioned this pull request Oct 7, 2019
Open
John Scoles and others added 23 commits October 27, 2019 08:49
Fix for GetBucketLocation content in root node of xml
7c492ff
s3 fix for GetBucketPolicy
f02bcb0
fix for S3 object tagging pplu#343
116793d
Fix for PutBucketAnalyticsConfiguration add in support for "xmlNamesp…
de6eb3a 
…ace" boto key
PutBucketCors GetBucketCors DeleteBucketCors all working add in suppo…
75927f3 
…rt trait for flattend request param
recommit of fix for PutBucketPolicy
ccd7bbf
Fix for PutBucketAcl but I think I also fixed the doubble name in req…
525fac1 
…uest and the flatten issues
Fix for XML attirbute on tag
077729c
Big fix for uri ecode and start of tests
08d44a3
Fix for GetBucketLocationOutput no need for boto change
f016512
@byterock
Merge branch 's3ObjectTagging' into s3-todo-cleanup
91808e0
@byterock
Merge pull request #1 from byterock/s3-todo-cleanup
eb48a44 
S3 todo cleanup move into S3 tagging so only one to fix them all
@byterock
Revert "S3 todo cleanup"
ee96fa0
@byterock
Merge pull request #2 from byterock/revert-1-s3-todo-cleanup
8086da5 
Revert "S3 todo cleanup" silly me I left in the changes to the template
Fix for bad pull updated these tests they all work now
00d2b50
Big fix up on test suite for S3 75% complete
370a7b1
Fixed two more bugs on caller and test request suite now complete
5f7740c
Final 09_request s3 test clean up
4c06170
template cleanup proper white space
b0edcbd
Final test fix up all tests past
1f96c2a
Clean up some code perl tidy
183ff92
Opps silly typo
6af2381
Done S3
4799589
@byterock
Copy link
Collaborator Author

byterock commented Dec 16, 2019

Ok here she is

  1. All S3 actions are working
  2. Full test stuite for S3 response and request
  3. All tests passing
  4. There are a few depricated which I did not bother to include
  1. PUT Bucket lifecycle
  2. GET Bucket lifecycle
  3. GetBucketNotification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@byterock @castaway