From 958ea885f5f83245c4f619847f774b20240777d8 Mon Sep 17 00:00:00 2001
From: Demetrio Girardi <dgirardi@prebid.org>
Date: Thu, 13 Jun 2024 11:54:24 -0700
Subject: [PATCH 1/2] improve duplicate checker

---
 .github/workflows/jscpd.yml | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/jscpd.yml b/.github/workflows/jscpd.yml
index b581bcd500e..da8af8687eb 100644
--- a/.github/workflows/jscpd.yml
+++ b/.github/workflows/jscpd.yml
@@ -1,6 +1,6 @@
 name: Check for Duplicated Code
 
-on: 
+on:
   pull_request_target:
     branches:
       - master
@@ -100,11 +100,14 @@ jobs:
           const fs = require('fs');
           const filteredReport = JSON.parse(fs.readFileSync('filtered-jscpd-report.json', 'utf8'));
           let comment = "Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:\n\n";
+          function link(dup) {
+             return `https://github.com/${{ github.event.repository.full_name }}/blob/${{ github.event.pull_request.head.sha }}/${dup.name}#L${dup.start}-L${dup.end}`
+          }
           filteredReport.forEach(duplication => {
-            const firstFile = duplication.firstFile.name;
-            const secondFile = duplication.secondFile.name;
+            const firstFile = duplication.firstFile;
+            const secondFile = duplication.secondFile;
             const lines = duplication.lines;
-            comment += `- \`${firstFile}\` has ${lines} duplicated lines with \`${secondFile}\`\n`;
+            comment += `- [\`${firstFile.name}\`](${link(firstFile)}) has ${lines} duplicated lines with [\`${secondFile.name}\`](${link(secondFile)})\n`;
           });
           comment += "\nReducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀";
           github.rest.issues.createComment({

From 52811139e62e10644b351df218d902abd658107c Mon Sep 17 00:00:00 2001
From: Demetrio Girardi <dgirardi@prebid.org>
Date: Thu, 13 Jun 2024 12:12:37 -0700
Subject: [PATCH 2/2] do not include exclusive end in linked block

---
 .github/workflows/jscpd.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/jscpd.yml b/.github/workflows/jscpd.yml
index da8af8687eb..21e7aadf97c 100644
--- a/.github/workflows/jscpd.yml
+++ b/.github/workflows/jscpd.yml
@@ -101,7 +101,7 @@ jobs:
           const filteredReport = JSON.parse(fs.readFileSync('filtered-jscpd-report.json', 'utf8'));
           let comment = "Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:\n\n";
           function link(dup) {
-             return `https://github.com/${{ github.event.repository.full_name }}/blob/${{ github.event.pull_request.head.sha }}/${dup.name}#L${dup.start}-L${dup.end}`
+             return `https://github.com/${{ github.event.repository.full_name }}/blob/${{ github.event.pull_request.head.sha }}/${dup.name}#L${dup.start}-L${dup.end - 1}`
           }
           filteredReport.forEach(duplication => {
             const firstFile = duplication.firstFile;