Skip to content

Wrong order of writing data #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MakisH opened this issue Mar 26, 2025 · 1 comment
Open

Wrong order of writing data #27

MakisH opened this issue Mar 26, 2025 · 1 comment
Labels

Comments

@MakisH
Copy link
Member

MakisH commented Mar 26, 2025

These should be reverted:

self.precice.write_data(self.nodesMeshName, self.writeDataNames[0], self.preciceNodeIndices, writeHCoeff)
self.precice.write_data(self.nodesMeshName, self.writeDataNames[1], self.preciceNodeIndices, writeTemp)

But we have a deeper issue here: Since we use a list (self.writeDataNames[0]) and not a dictionary, it is easy to mess up the order. These are set here:

def setDataNames(self, names):
for writeDataName in names["write-data"]:
if writeDataName.find("Heat-Transfer-Coefficient-Solid") >= 0:
self.writeDataNames.append(writeDataName)
elif writeDataName.find("Sink-Temperature-Solid") >= 0:
self.writeDataNames.append(writeDataName)
for readDataName in names["read-data"]:
if readDataName.find("Heat-Transfer-Coefficient-Fluid") >= 0:
self.readData[readDataName] = None
elif readDataName.find("Sink-Temperature-Fluid") >= 0:
self.readData[readDataName] = None

Reported by a user in the forum: https://precice.discourse.group/t/unexpectedly-high-interface-temperature-in-openfoam-code-aster-heat-transfer-coupling/2377/4

@MakisH MakisH added the bug label Mar 26, 2025
@precice-bot
Copy link

This issue has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/unexpectedly-high-interface-temperature-in-openfoam-code-aster-heat-transfer-coupling/2377/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants