Bundle everything into the npm module

[kddnewton]

See this issue: #1232 for details.

I'm not entirely sure how to solve this, but I know it will involve adding a prepublishOnly step to the package.json that's going to use bundler to dump all of the necessary files into the package somehow.

[JounQin]

Is that possible to compile Ruby as WASM?

[kddnewton]

Yes it is! But only with Ruby 3.2. So in the future that’ll be a great solution.

…

On Fri, Jul 22, 2022 at 9:12 PM JounQin ***@***.***> wrote: Is that possible to compile Ruby as WASM? — Reply to this email directly, view it on GitHub <#1260 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG3P3XOVU4TR7GWDE5IYATVVNBGLANCNFSM54MJACEA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[JounQin]

Why not try it out right now?

https://www.ruby-lang.org/en/news/2022/04/03/ruby-3-2-0-preview1-released/

Is there anything preventing us?

When it's already compiled into WASM, no ruby runtime is required.

[kddnewton]

Right... I don't know what I was talking about. I will try this!

[JounQin]

Besides, in case of handling asynchronous due to WASM, you can try https://github.com/un-ts/synckit to turn it synchronously again!

[kddnewton]

So this now works in https://github.com/ruby-syntax-tree/node-syntax-tree. Except that it doesn't support RBS yet, because it's very difficult to compile non-bundled native extensions: https://twitter.com/kateinoigakukun/status/1555202638064799750?s=20&t=9wXaP7QoPngehSIujvUGFw.

The other difficulty is that loading WASM requires an async call, so we still are blocked on that. Fortunately that's changing in v3 of prettier prettier/prettier#13142.

I think the answer for now is going to be waiting for prettier v3 and waiting on/working on support for non-bundled native extensions for WASI.

[JounQin]

Besides, in case of handling asynchronous due to WASM, you can try https://github.com/un-ts/synckit to turn it synchronously again!

@kddnewton Did you tried this one? Of course waiting for prettier@v3 is another solution. 😅

[kddnewton]

@JounQin I did! I couldn't get it to work. To be honest I'm not sure what I was doing wrong, but it would just hang no matter what I tried.

[JounQin]

@JounQin I did! I couldn't get it to work. To be honest I'm not sure what I was doing wrong, but it would just hang no matter what I tried.

@kddnewton Can you provide a branch so I can offer some help?

At least you can try SYNCKIT_TIMEOUT env to see what's wrong.

And the problem may be fixed by un-ts/synckit#94

[kddnewton]

@JounQin sure! The branch is here: https://github.com/prettier/plugin-ruby/tree/synckit.

[JounQin]

I haven't looked into details yet, but the root issue could be

23f2089#diff-598b75d6dc772eb13aa7141f35bb93046ae26c58a97e8647ecf7f74aec8ae93fR2

It does not need/should be called immediately

- const parseSync = createSyncFn(require.resolve("./worker"))();
+ const parseSync = createSyncFn(require.resolve("./worker"));

I'll clone and check quickly.

[kddnewton]

Nice, now I'm just getting some cloning errors.

[kddnewton]

Okay @JounQin we're back to hanging now

[JounQin]

Nice, now I'm just getting some cloning errors.

See

You must make sure, the result is serializable by Structured Clone Algorithm

---

Besides, you'd better upgrade to synckit@0.8.2 which propagates sync errors from worker, it'll handle some unexpected sync errors.