-
Notifications
You must be signed in to change notification settings - Fork 74
Open
Description
This code
Line 234 in b3571fd
| par_shapes_merge(a, b); |
creates a disk and a dodecahedron and then calls
par_shapes_merge on them. The problem is that the disk has normals but the dodecahedron does not.Line 685 in b3571fd
| if (src->normals || dst->normals) { |
allocates enough space for normals of both but since the second has none it leaves part of the buffer uninitialized. Later when the code tries to read normals it gets uninitialized values.
You should either
- fail the operation when one mesh has normals and the other doesn't
- build the missing normals automatically
- clear the buffer to zero if normals are missing
Not sure which is best.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels