Skip to content

Commit 53bdd38

Browse files
Copilotpksjce
andauthored
Remove unused renderWithTheme helper from Breadcrumbs tests (#7082)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pksjce <417268+pksjce@users.noreply.github.com>
1 parent aa3e081 commit 53bdd38

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import Breadcrumbs from '..'
22
import {render as HTMLRender, screen, waitFor, within} from '@testing-library/react'
33
import {describe, expect, it, vi} from 'vitest'
44
import userEvent from '@testing-library/user-event'
5-
// Helper function kept for symmetry (flags removed); directly renders component
6-
const renderWithTheme = (component: React.ReactElement) => HTMLRender(component)
75

86
// Mock ResizeObserver for tests
97
const mockObserve = vi.fn()
@@ -53,7 +51,7 @@ describe('Breadcrumbs', () => {
5351
})
5452

5553
it('sets data-overflow attribute when overflow is menu', () => {
56-
const {container} = renderWithTheme(
54+
const {container} = HTMLRender(
5755
<Breadcrumbs overflow="menu">
5856
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
5957
</Breadcrumbs>,
@@ -63,7 +61,7 @@ describe('Breadcrumbs', () => {
6361
})
6462

6563
it('sets data-overflow attribute when overflow is wrap', () => {
66-
const {container} = renderWithTheme(
64+
const {container} = HTMLRender(
6765
<Breadcrumbs overflow="wrap">
6866
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
6967
</Breadcrumbs>,
@@ -73,7 +71,7 @@ describe('Breadcrumbs', () => {
7371
})
7472

7573
it('renders all items when overflow is wrap', () => {
76-
renderWithTheme(
74+
HTMLRender(
7775
<Breadcrumbs overflow="wrap">
7876
<Breadcrumbs.Item href="/1">Item 1</Breadcrumbs.Item>
7977
<Breadcrumbs.Item href="/2">Item 2</Breadcrumbs.Item>
@@ -94,7 +92,7 @@ describe('Breadcrumbs', () => {
9492
})
9593

9694
it('shows overflow menu when more than 5 items in menu mode', () => {
97-
renderWithTheme(
95+
HTMLRender(
9896
<Breadcrumbs overflow="menu">
9997
<Breadcrumbs.Item href="/1">Item 1</Breadcrumbs.Item>
10098
<Breadcrumbs.Item href="/2">Item 2</Breadcrumbs.Item>
@@ -117,7 +115,7 @@ describe('Breadcrumbs', () => {
117115

118116
it('show root in menu', () => {
119117
expect(() => {
120-
renderWithTheme(
118+
HTMLRender(
121119
<Breadcrumbs overflow="menu-with-root">
122120
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
123121
<Breadcrumbs.Item href="/docs">Docs</Breadcrumbs.Item>
@@ -129,7 +127,7 @@ describe('Breadcrumbs', () => {
129127
it('includes root item in overflow menu when overflow is menu-with-root', async () => {
130128
const user = userEvent.setup()
131129

132-
renderWithTheme(
130+
HTMLRender(
133131
<Breadcrumbs overflow="menu-with-root">
134132
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
135133
<Breadcrumbs.Item href="/category">Category</Breadcrumbs.Item>
@@ -175,7 +173,7 @@ describe('Breadcrumbs', () => {
175173
})
176174

177175
it('renders accessible overflow menu', () => {
178-
renderWithTheme(
176+
HTMLRender(
179177
<Breadcrumbs overflow="menu">
180178
<Breadcrumbs.Item href="/1">Item 1</Breadcrumbs.Item>
181179
<Breadcrumbs.Item href="/2">Item 2</Breadcrumbs.Item>
@@ -203,7 +201,7 @@ describe('Breadcrumbs', () => {
203201
})
204202
globalThis.ResizeObserver = mockResizeObserver
205203

206-
renderWithTheme(
204+
HTMLRender(
207205
<Breadcrumbs overflow="menu">
208206
<Breadcrumbs.Item href="/1">Item 1</Breadcrumbs.Item>
209207
<Breadcrumbs.Item href="/2">Item 2</Breadcrumbs.Item>
@@ -262,7 +260,7 @@ describe('Breadcrumbs', () => {
262260

263261
const user = userEvent.setup()
264262

265-
renderWithTheme(
263+
HTMLRender(
266264
<Breadcrumbs overflow="menu">
267265
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
268266
<Breadcrumbs.Item href="/category">Category</Breadcrumbs.Item>
@@ -347,7 +345,7 @@ describe('Breadcrumbs', () => {
347345
it('closes menu on Escape key press', async () => {
348346
const user = userEvent.setup()
349347

350-
renderWithTheme(
348+
HTMLRender(
351349
<Breadcrumbs overflow="menu">
352350
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
353351
<Breadcrumbs.Item href="/docs">Docs</Breadcrumbs.Item>
@@ -383,7 +381,7 @@ describe('Breadcrumbs', () => {
383381
it('closes menu when clicking outside', async () => {
384382
const user = userEvent.setup()
385383

386-
renderWithTheme(
384+
HTMLRender(
387385
<div>
388386
<button type="button" data-testid="outside-button">
389387
Outside Button
@@ -423,7 +421,7 @@ describe('Breadcrumbs', () => {
423421
it('allows tab navigation through menu items', async () => {
424422
const user = userEvent.setup()
425423

426-
renderWithTheme(
424+
HTMLRender(
427425
<Breadcrumbs overflow="menu">
428426
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
429427
<Breadcrumbs.Item href="/docs">Docs</Breadcrumbs.Item>
@@ -462,7 +460,7 @@ describe('Breadcrumbs', () => {
462460
it('maintains focus on menu button when menu is closed', async () => {
463461
const user = userEvent.setup()
464462

465-
renderWithTheme(
463+
HTMLRender(
466464
<Breadcrumbs overflow="menu">
467465
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
468466
<Breadcrumbs.Item href="/docs">Docs</Breadcrumbs.Item>
@@ -499,7 +497,7 @@ describe('Breadcrumbs', () => {
499497

500498
describe('variant prop (feature flag on)', () => {
501499
it('sets data-variant="normal" by default', () => {
502-
const {container} = renderWithTheme(
500+
const {container} = HTMLRender(
503501
<Breadcrumbs overflow="menu">
504502
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
505503
<Breadcrumbs.Item href="/docs" selected>
@@ -511,7 +509,7 @@ describe('Breadcrumbs', () => {
511509
})
512510

513511
it('sets data-variant="spacious" when variant prop provided', () => {
514-
const {container} = renderWithTheme(
512+
const {container} = HTMLRender(
515513
<Breadcrumbs overflow="menu" variant="spacious">
516514
<Breadcrumbs.Item href="/home">Home</Breadcrumbs.Item>
517515
<Breadcrumbs.Item href="/docs" selected>

0 commit comments

Comments
 (0)