From 9071055adff2d80e3954db6591761ed91bb61d73 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Fri, 19 Sep 2025 14:01:03 +0200 Subject: [PATCH 1/9] ConfirmationDialog --- .../ConfirmationDialog.features.stories.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/react/src/ConfirmationDialog/ConfirmationDialog.features.stories.tsx b/packages/react/src/ConfirmationDialog/ConfirmationDialog.features.stories.tsx index 4fa7a953b3f..f7e643e5413 100644 --- a/packages/react/src/ConfirmationDialog/ConfirmationDialog.features.stories.tsx +++ b/packages/react/src/ConfirmationDialog/ConfirmationDialog.features.stories.tsx @@ -1,7 +1,6 @@ import type React from 'react' import {useState, useCallback} from 'react' import type {Meta} from '@storybook/react-vite' -import {useTheme} from '..' import {Button} from '../Button' import {ActionMenu} from '../ActionMenu' import {ActionList} from '../ActionList' @@ -15,18 +14,17 @@ export default { export const ShorthandHook = () => { const confirm = useConfirm() - const {theme} = useTheme() const onButtonClick = useCallback( async (event: React.MouseEvent) => { if ( (await confirm({title: 'Are you sure?', content: 'Do you really want to turn this button green?'})) && event.target instanceof HTMLElement ) { - event.target.style.color = theme?.colors.success.fg ?? 'green' + event.target.style.color = 'var(--fgColor-success)' event.target.textContent = "I'm green!" } }, - [confirm, theme], + [confirm], ) return (
From 2590fba0be6796a494a6e02e1af62c25b1d7ec96 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Fri, 19 Sep 2025 14:01:06 +0200 Subject: [PATCH 2/9] Overlay --- packages/react/src/Overlay/Overlay.tsx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/react/src/Overlay/Overlay.tsx b/packages/react/src/Overlay/Overlay.tsx index aa9cfc1e374..7b661537e1f 100644 --- a/packages/react/src/Overlay/Overlay.tsx +++ b/packages/react/src/Overlay/Overlay.tsx @@ -1,7 +1,6 @@ import type {ComponentPropsWithRef, ReactElement} from 'react' import React, {useEffect, useRef} from 'react' import useLayoutEffect from '../utils/useIsomorphicLayoutEffect' -import {get} from '../constants' import type {AriaRole, Merge} from '../utils/types' import type {TouchOrMouseEvent} from '../hooks' import {useOverlay} from '../hooks' @@ -9,12 +8,12 @@ import Portal from '../Portal' import type {SxProp} from '../sx' import {useRefObjectAsForwardedRef} from '../hooks/useRefObjectAsForwardedRef' import type {AnchorSide} from '@primer/behaviors' -import {useTheme} from '../ThemeProvider' import type {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/polymorphic' import {useFeatureFlag} from '../FeatureFlags' import classes from './Overlay.module.css' import {clsx} from 'clsx' import {BoxWithFallback} from '../internal/components/BoxWithFallback' +import theme from '../theme' type StyledOverlayProps = { width?: keyof typeof widthMap @@ -194,9 +193,8 @@ const Overlay = React.forwardRef( ): ReactElement => { const overlayRef = useRef(null) useRefObjectAsForwardedRef(forwardedRef, overlayRef) - const {theme} = useTheme() - const slideAnimationDistance = parseInt(get('space.2')(theme).replace('px', '')) - const slideAnimationEasing = get('animation.easeOutCubic')(theme) + const slideAnimationDistance = 8 // hardcoded value for --base-size-2 or theme.space[2] + const slideAnimationEasing = theme.animation.easeOutCubic useOverlay({ overlayRef, From 9a9d4caf21a51eeb194e93089314d88d60a21bfc Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Fri, 19 Sep 2025 14:01:12 +0200 Subject: [PATCH 3/9] UnderlineNav --- packages/react/src/UnderlineNav/UnderlineNav.tsx | 7 ++----- packages/react/src/UnderlineNav/UnderlineNavContext.tsx | 3 --- packages/react/src/UnderlineNav/styles.ts | 7 +++---- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/packages/react/src/UnderlineNav/UnderlineNav.tsx b/packages/react/src/UnderlineNav/UnderlineNav.tsx index c0f44fe244c..510f8c6f980 100644 --- a/packages/react/src/UnderlineNav/UnderlineNav.tsx +++ b/packages/react/src/UnderlineNav/UnderlineNav.tsx @@ -6,10 +6,9 @@ import sx from '../sx' import {UnderlineNavContext} from './UnderlineNavContext' import type {ResizeObserverEntry} from '../hooks/useResizeObserver' import {useResizeObserver} from '../hooks/useResizeObserver' -import {useTheme} from '../ThemeProvider' import type {ChildWidthArray, ResponsiveProps, ChildSize} from './types' import VisuallyHidden from '../_VisuallyHidden' -import {moreBtnStyles, getDividerStyle, menuStyles, menuItemStyles, baseMenuStyles, baseMenuMinWidth} from './styles' +import {moreBtnStyles, dividerStyles, menuStyles, menuItemStyles, baseMenuStyles, baseMenuMinWidth} from './styles' import {UnderlineItemList, UnderlineWrapper, LoadingCounter, GAP} from '../internal/components/UnderlineTabbedInterface' import styled from 'styled-components' import {Button} from '../Button' @@ -161,7 +160,6 @@ export const UnderlineNav = forwardRef( const containerRef = React.useRef(null) const disclosureWidgetId = useId() - const {theme} = useTheme() const [isWidgetOpen, setIsWidgetOpen] = useState(false) const [iconsVisible, setIconsVisible] = useState(true) const [childWidthArray, setChildWidthArray] = useState([]) @@ -308,7 +306,6 @@ export const UnderlineNav = forwardRef( return ( 0 && ( - {!onlyMenuVisible && } + {!onlyMenuVisible && }