From 434d5fd52ea3f5ead0a27f9f3ddbaa92879a3df7 Mon Sep 17 00:00:00 2001 From: fr0mano Date: Mon, 10 Nov 2025 22:07:26 +0800 Subject: [PATCH 1/2] chore: Fix typos --- contributor-docs/adrs/adr-009-behavior-isolation.md | 2 +- packages/react/src/KeybindingHint/key-names.ts | 2 +- packages/react/src/NavList/NavList.figma.tsx | 2 +- packages/react/src/ThemeProvider.tsx | 2 +- packages/react/src/VisuallyHidden/VisuallyHidden.tsx | 2 +- .../components/UnderlineTabbedInterface.module.css | 7 ++++--- 6 files changed, 9 insertions(+), 8 deletions(-) diff --git a/contributor-docs/adrs/adr-009-behavior-isolation.md b/contributor-docs/adrs/adr-009-behavior-isolation.md index c4fb2bb1877..e575d0b70dd 100644 --- a/contributor-docs/adrs/adr-009-behavior-isolation.md +++ b/contributor-docs/adrs/adr-009-behavior-isolation.md @@ -208,4 +208,4 @@ Organizational overhead of shared dependencies is something that we will have to ## Consequences - By using `@lit-labs/ssr` today, we introduce a new dependency into Primer React. This may be removed later should React support Custom Elements out of the box (which seems likely for React 19), but for now we will need to continue to ship this dependency. -- This decision may expediate the need to resolve organisational overhead issues. Deciding to use custom elements to share more code among PVC and PRC may highlight other areas which need to be addressed in subsequent PRs. +- This decision may expedite the need to resolve organisational overhead issues. Deciding to use custom elements to share more code among PVC and PRC may highlight other areas which need to be addressed in subsequent PRs. diff --git a/packages/react/src/KeybindingHint/key-names.ts b/packages/react/src/KeybindingHint/key-names.ts index de5eb5e95bb..6d0543656b4 100644 --- a/packages/react/src/KeybindingHint/key-names.ts +++ b/packages/react/src/KeybindingHint/key-names.ts @@ -75,7 +75,7 @@ export const accessibleKeyName = (key: string, isMacOS: boolean) => printscreen: 'print screen', // We don't need to represent _every_ symbol - only those found on standard keyboards. // Other symbols should be avoided as keyboard shortcuts anyway. - // These should match the colloqiual names of the keys, not the names of the symbols. Ie, + // These should match the colloquial names of the keys, not the names of the symbols. Ie, // "Equals" not "Equal Sign", "Dash" not "Minus", "Period" not "Dot", etc. '`': 'backtick', '~': 'tilde', diff --git a/packages/react/src/NavList/NavList.figma.tsx b/packages/react/src/NavList/NavList.figma.tsx index bf04ff1446f..1ac2fddde9b 100644 --- a/packages/react/src/NavList/NavList.figma.tsx +++ b/packages/react/src/NavList/NavList.figma.tsx @@ -37,7 +37,7 @@ figma.connect( example: ({actionList}) => {actionList.text}, }, ) -/** Collapsable item **/ +/** Collapsible item **/ figma.connect( NavList.Item, 'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=16716-62586&m=dev', diff --git a/packages/react/src/ThemeProvider.tsx b/packages/react/src/ThemeProvider.tsx index 1fc1fb5e067..75a10b07b2b 100644 --- a/packages/react/src/ThemeProvider.tsx +++ b/packages/react/src/ThemeProvider.tsx @@ -44,7 +44,7 @@ const getServerHandoff = (id: string) => { const serverData = document.getElementById(`__PRIMER_DATA_${id}__`)?.textContent if (serverData) return JSON.parse(serverData) } catch (_error) { - // if document/element does not exist or JSON is invalid, supress error + // if document/element does not exist or JSON is invalid, suppress error } return {} } diff --git a/packages/react/src/VisuallyHidden/VisuallyHidden.tsx b/packages/react/src/VisuallyHidden/VisuallyHidden.tsx index 84b23110742..d05c496352f 100644 --- a/packages/react/src/VisuallyHidden/VisuallyHidden.tsx +++ b/packages/react/src/VisuallyHidden/VisuallyHidden.tsx @@ -5,7 +5,7 @@ import classes from './VisuallyHidden.module.css' /** * Provides a component that implements the "visually hidden" technique. This is - * analagous to the common `sr-only` class. Children that are rendered inside + * analogous to the common `sr-only` class. Children that are rendered inside * this component will not be visible but will be available to screen readers. * * Note: if this component, or a descendant, has focus then this component will diff --git a/packages/react/src/internal/components/UnderlineTabbedInterface.module.css b/packages/react/src/internal/components/UnderlineTabbedInterface.module.css index c0bc0b4d9a4..b8aee1802c3 100644 --- a/packages/react/src/internal/components/UnderlineTabbedInterface.module.css +++ b/packages/react/src/internal/components/UnderlineTabbedInterface.module.css @@ -8,7 +8,7 @@ /* make space for the underline */ min-height: var(--control-xlarge-size, 48px); - /* using a box-shadow instead of a border to accomodate 'overflow-y: hidden' on UnderlinePanels */ + /* using a box-shadow instead of a border to accommodate 'overflow-y: hidden' on UnderlinePanels */ /* stylelint-disable-next-line primer/box-shadow */ box-shadow: inset 0 -1px var(--borderColor-muted); @@ -136,7 +136,8 @@ .LoadingCounter { display: inline-block; width: 1.5rem; - height: 1rem; /* 16px */ + height: 1rem; + /* 16px */ background-color: var(--bgColor-neutral-muted); border-color: var(--borderColor-default); /* stylelint-disable-next-line primer/borders */ @@ -152,4 +153,4 @@ to { opacity: 0.2; } -} +} \ No newline at end of file From 39b11e25554f83528cb0a7c058138ee85108de9b Mon Sep 17 00:00:00 2001 From: Josh Black Date: Mon, 17 Nov 2025 10:22:03 -0600 Subject: [PATCH 2/2] chore: run format --- .../src/internal/components/UnderlineTabbedInterface.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/internal/components/UnderlineTabbedInterface.module.css b/packages/react/src/internal/components/UnderlineTabbedInterface.module.css index b8aee1802c3..85214c5c317 100644 --- a/packages/react/src/internal/components/UnderlineTabbedInterface.module.css +++ b/packages/react/src/internal/components/UnderlineTabbedInterface.module.css @@ -153,4 +153,4 @@ to { opacity: 0.2; } -} \ No newline at end of file +}