Skip to content

Put storage behind an interface in irmaclient #419

@w-ensink

Description

@w-ensink

I propose an architecture that looks somewhat like this:

classDiagram
    class IdemixCredentialStorage {
        <<interface>>
        +StoreIdemix(credential)
        +LoadIdemix(id)
    }

    class LogStorage {
        <<interface>>
        +StoreLog(log)
        +LoadLogs()
    }

    class SdJwtVcStorage {
        <<interface>>
        +StoreSdJwtVc(credential)
        +LoadSdJwtVc(id)
    }

    class Storage {
        +StoreSdJwtVc(credential)
        +LoadSdJwtVc(id)
        +StoreIdemix(credential)
        +LoadIdemix(id)
        +StoreLog(log)
        +LoadLogs()
    }

    IdemixCredentialStorage <|-- Storage
    SdJwtVcStorage <|-- Storage
    LogStorage <|-- Storage

    class IrmaClient
    class OpenID4VPClient
    
    IrmaClient *-- IdemixCredentialStorage
    IrmaClient *-- LogStorage
    OpenID4VPClient *-- SdJwtVcStorage
    OpenID4VPClient *-- LogStorage
Loading

This will keep components nicely separated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions